From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Two issues found with -fsanitize=undefined
Date: Mon, 21 Sep 2015 22:34:09 +0200 [thread overview]
Message-ID: <20150921203409.GB8913@x4> (raw)
In-Reply-To: <20150921212113.74706d86@ntlworld.com>
On 2015.09.21 at 21:21 +0100, Peter Stephenson wrote:
> On Mon, 21 Sep 2015 22:04:13 +0200
> Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
> > Yes:
> > matchbuflen: (null) with no matchbuf: 0
> > It looks like the issue doesn't happen with a -DDEBUG build.
> > I've changed the DPUTS line to:
> > fprintf(stderr, "matchbuflen: %s with no matchbuf: %x", matchbuf, matchbuflen);
>
> That's fine. If matchbuf is NULL, matchbuflen *should* be 0.
>
> I presume you're missing that
>
> DPUTS(matchbuflen, "matchbuflen with no matchbuf");
>
> is (roughly) equivalent to
>
> if (matchbuflen)
> fprintf(stderr, "matchbuflen with no matcbuf");
Well, only if DEBUG is defined. And as I wrote above the issue doesn't
happen at all for -DDEBUG.
--
Markus
next prev parent reply other threads:[~2015-09-21 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:57 Markus Trippelsdorf
2015-09-17 17:16 ` Bart Schaefer
2015-09-17 17:24 ` Markus Trippelsdorf
2015-09-17 17:41 ` Bart Schaefer
2015-09-19 19:57 ` Peter Stephenson
2015-09-19 20:18 ` Markus Trippelsdorf
2015-09-19 22:35 ` Peter Stephenson
2015-09-20 4:09 ` Bart Schaefer
2015-09-21 12:46 ` Peter Stephenson
2015-09-21 19:13 ` Peter Stephenson
2015-09-21 20:04 ` Markus Trippelsdorf
2015-09-21 20:21 ` Peter Stephenson
2015-09-21 20:34 ` Markus Trippelsdorf [this message]
2015-09-21 20:56 ` Bart Schaefer
2015-09-22 0:02 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921203409.GB8913@x4 \
--to=markus@trippelsdorf.de \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).