zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Vasil <mailing_lists@petervasil.net>
Cc: zsh-workers@zsh.org
Subject: Re: edit-command-line problem with emacsclient
Date: Mon, 21 Sep 2015 21:16:43 +0000	[thread overview]
Message-ID: <20150921211643.GJ1955@tarsus.local2> (raw)
In-Reply-To: <55FE9C92.7030203@petervasil.net>

Peter Vasil wrote on Sun, Sep 20, 2015 at 13:46:26 +0200:
> Commit 35ffe36318955d03fca3df0d34a0997970cfc6a3 introduced the change,
> that when calling edit-command-line, the curser is put to the right offset.
> 

I wrote that.  Sorry for the bug.  I'm a vim user, and I sanity-tested
the emacs case, but I don't actually speak emacs lisp, so I'm not
surprised the patch was complete but not sound.  I see now I forgot to
state in the patch mail that the emacs codepath needed extra review :-/

Cheers,

Daniel
(OT: Perhaps I should add "I don't speak emacs lisp" to https://people.apache.org/~danielsh/bilmiyorum/?)

> This is implemented for vim and emacs, however if I set my EDITOR or
> VISUAL to emacsclient, the *emacs* condition gets called which does not
> work for emacsclient. The arguments specidied for emacs work only for
> Emacs but not for emacsclient.
> 
> It would be great to change the condition *emacs* that it does not match
> emacsclient or add another condition for emacsclient with appropriate
> arguments.
> 
> Thanks and bests,
> Peter
> 


  parent reply	other threads:[~2015-09-21 21:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 11:46 Peter Vasil
2015-09-20 15:32 ` Bart Schaefer
     [not found]   ` <55FF3CE5.9070604@petervasil.net>
2015-09-21  4:06     ` Bart Schaefer
     [not found]       ` <56004B05.9000703@petervasil.net>
     [not found]         ` <150921120017.ZM426@torch.brasslantern.com>
2015-09-21 19:09           ` Peter Vasil
2015-09-21 21:16 ` Daniel Shahaf [this message]
2015-09-21 22:31   ` Bart Schaefer
2015-09-22  7:10     ` Peter Vasil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150921211643.GJ1955@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=mailing_lists@petervasil.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).