From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: WARN_CREATE_GLOBAL and parameters used by the shell
Date: Fri, 20 Nov 2015 12:01:17 +0000 [thread overview]
Message-ID: <20151120120117.28b4ee9d@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20151120115538.GB25070@cventin.lip.ens-lyon.fr>
On Fri, 20 Nov 2015 12:55:38 +0100
Vincent Lefevre <vincent@vinc17.net> wrote:
> There's a problem with smart-insert-last-word:
>
> smart-insert-last-word:63: scalar parameter _ilw_lcursor created globally in function
> smart-insert-last-word:76: scalar parameter _ilw_hist created globally in function
> smart-insert-last-word:77: scalar parameter _ilw_count created globally in function
> smart-insert-last-word:122: scalar parameter _ilw_cursor created globally in function
> smart-insert-last-word:125: scalar parameter _ilw_changeno created globally in function
>
Those are all intentional.
pws
diff --git a/Functions/Zle/smart-insert-last-word b/Functions/Zle/smart-insert-last-word
index 67adea7..cf8715d 100644
--- a/Functions/Zle/smart-insert-last-word
+++ b/Functions/Zle/smart-insert-last-word
@@ -60,7 +60,7 @@ then
lcursor=$_ilw_lcursor
else
NUMERIC=1
- _ilw_lcursor=$lcursor
+ typeset -g _ilw_lcursor=$lcursor
fi
# Handle the up to three arguments of .insert-last-word
if (( $+1 ))
@@ -73,8 +73,8 @@ then
(( NUMERIC )) || LBUFFER[lcursor+1,cursor+1]=''
numeric=$((-(${2:--numeric})))
fi
-_ilw_hist=$HISTNO
-_ilw_count=$NUMERIC
+typeset -g _ilw_hist=$HISTNO
+typeset -g _ilw_count=$NUMERIC
if [[ -z "$numeric" ]]
then
@@ -119,7 +119,7 @@ fi
(( NUMERIC > $#lastcmd )) && return 1
LBUFFER[lcursor+1,cursor+1]=$lastcmd[-NUMERIC]
-_ilw_cursor=$CURSOR
+typeset -g _ilw_cursor=$CURSOR
# This is necessary to update UNDO_CHANGE_NO immediately
-zle split-undo && _ilw_changeno=$UNDO_CHANGE_NO
+zle split-undo && typeset -g _ilw_changeno=$UNDO_CHANGE_NO
prev parent reply other threads:[~2015-11-20 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 11:44 Vincent Lefevre
2015-11-20 11:49 ` Peter Stephenson
2015-11-20 11:55 ` Vincent Lefevre
2015-11-20 12:01 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120120117.28b4ee9d@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).