From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: WARN_CREATE_GLOBAL and parameters used by the shell
Date: Fri, 20 Nov 2015 11:49:48 +0000 [thread overview]
Message-ID: <20151120114948.6edc448a@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20151120114456.GA24924@cventin.lip.ens-lyon.fr>
On Fri, 20 Nov 2015 12:44:56 +0100
Vincent Lefevre <vincent@vinc17.net> wrote:
> I think that when WARN_CREATE_GLOBAL is set, one should get no warnings
> for parameters used by the shell, as their intent is to be global.
Yes, we need to ignore specials, which are already in the namespace
anyway.
pws
diff --git a/Src/params.c b/Src/params.c
index 3ed771e..b121bd6 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -2702,7 +2702,7 @@ check_warn_create(Param pm, const char *pmtype)
Funcstack i;
const char *name;
- if (pm->level != 0)
+ if (pm->level != 0 || (pm->node.flags & PM_SPECIAL))
return;
name = NULL;
next prev parent reply other threads:[~2015-11-20 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 11:44 Vincent Lefevre
2015-11-20 11:49 ` Peter Stephenson [this message]
2015-11-20 11:55 ` Vincent Lefevre
2015-11-20 12:01 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120114948.6edc448a@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).