From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: zsh 5.1.1-test-1
Date: Sun, 22 Nov 2015 15:31:08 +0000 [thread overview]
Message-ID: <20151122153108.6054abfc@ntlworld.com> (raw)
In-Reply-To: <20151121190908.GA1249@ruderich.org>
On Sat, 21 Nov 2015 20:09:08 +0100
Simon Ruderich <simon@ruderich.org> wrote:
> However on startup with my zshrc I get the following error from
> VCS_info:
>
> VCS_INFO_maxexports:7: array parameter zle_bracketed_paste created globally in function VCS_INFO_maxexports
That's an exception --- the variable so created is intended to be
global, so needs to be treated specially.
> VCS_INFO_nvcsformats:13: array parameter msgs created globally in function VCS_INFO_nvcsformats
That's not --- msgs needs to be local within the function, so this is
the warning doing its job properly.
Thanks for these --- I'm sure there are more when people get around to
running their favourite distributed functions with the latest coe.
> Btw. it would be really nice if we could get signed releases
> (signed git tag and signature files for the tarballs). Having to
> download untrusted code and just running it is something I'd like
> to avoid. Especially useful for distributions which provide those
> sources to many users.
This has been mentioned before and I'm happy to go along with it if
someone who knows what they're doing wants to set it up / establish
ground rules. I'll need to set up a gpg key as it doesn't like my
existing PGP key.
(The idea that a tag signed by me is somehow "safer" than anything else
on the master branch in the git repository is a bit far-fetched, but
that's a different issue; nothing wrong with using the state of the art
technology.)
pws
diff --git a/Functions/VCS_Info/VCS_INFO_nvcsformats b/Functions/VCS_Info/VCS_INFO_nvcsformats
index 581aa5a..203a86d 100644
--- a/Functions/VCS_Info/VCS_INFO_nvcsformats
+++ b/Functions/VCS_Info/VCS_INFO_nvcsformats
@@ -4,6 +4,7 @@
setopt localoptions noksharrays NO_shwordsplit
local c v rr
+local -a msgs
if [[ $1 == '-preinit-' ]] ; then
c='default'
diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c
index 593d636..38427e8 100644
--- a/Src/Zle/zle_main.c
+++ b/Src/Zle/zle_main.c
@@ -2045,7 +2045,8 @@ setup_(UNUSED(Module m))
bpaste = zshcalloc(3*sizeof(char *));
bpaste[0] = ztrdup("\033[?2004h");
bpaste[1] = ztrdup("\033[?2004l");
- setaparam("zle_bracketed_paste", bpaste);
+ /* Intended to be global, no WARNCREATEGLOBAL check. */
+ assignaparam("zle_bracketed_paste", bpaste, 0);
return 0;
}
next prev parent reply other threads:[~2015-11-22 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 18:35 Peter Stephenson
2015-11-21 18:54 ` Pascal Wittmann
2015-11-21 19:09 ` Simon Ruderich
2015-11-21 22:25 ` Bart Schaefer
2015-11-22 14:31 ` Christian Heinrich
2015-11-22 15:31 ` Peter Stephenson [this message]
2015-11-24 7:41 ` Simon Ruderich
2015-11-21 23:01 ` Test/V01private.ztst skipped (was: zsh 5.1.1-test-1) Daniel Shahaf
2015-11-22 1:09 ` Bart Schaefer
2015-11-25 1:44 ` Daniel Shahaf
2015-11-22 1:14 ` Bart Schaefer
2015-11-22 7:51 ` Bart Schaefer
2015-11-22 10:54 ` zsh 5.1.1-test-1 Sebastian Gniazdowski
2015-11-22 11:48 ` Manuel Presnitz
2015-11-22 12:23 ` Mikael Magnusson
2015-11-22 16:09 ` Peter Stephenson
2015-11-22 16:52 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151122153108.6054abfc@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).