From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "Manuel Presnitz" <mpy@gmx.net>
Cc: zsh-workers@zsh.org
Subject: Re: zsh 5.1.1-test-1
Date: Sun, 22 Nov 2015 16:09:55 +0000 [thread overview]
Message-ID: <20151122160955.0cc6da24@ntlworld.com> (raw)
In-Reply-To: <201511221248360141.002B54E3@gateway.core.mpy.ch>
On Sun, 22 Nov 2015 12:48:36 +0100
"Manuel Presnitz" <mpy@gmx.net> wrote:
> I experience problems with this command
> $ hash -m 'foo'
> which hangs infinitely
Yes, it's infinite; it's a simple missing increment. (Took a while for
the penny to break out of the non-dropping loop while I scratched my
head over search algorithms...)
I'm wondering, having just looked, whether it's safe to use a variable-size
array for all the hash nodes in the command table when sorting? That's
using up quite a lot of stack.
pws
diff --git a/Src/builtin.c b/Src/builtin.c
index 01eb5b8..cac4f42 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3712,6 +3712,7 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
zwarnnam(name, "bad pattern : %s", *argv);
returnval = 1;
}
+ argv++;
continue;
}
if (!(asg = getasg(&argv, NULL))) {
next prev parent reply other threads:[~2015-11-22 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 18:35 Peter Stephenson
2015-11-21 18:54 ` Pascal Wittmann
2015-11-21 19:09 ` Simon Ruderich
2015-11-21 22:25 ` Bart Schaefer
2015-11-22 14:31 ` Christian Heinrich
2015-11-22 15:31 ` Peter Stephenson
2015-11-24 7:41 ` Simon Ruderich
2015-11-21 23:01 ` Test/V01private.ztst skipped (was: zsh 5.1.1-test-1) Daniel Shahaf
2015-11-22 1:09 ` Bart Schaefer
2015-11-25 1:44 ` Daniel Shahaf
2015-11-22 1:14 ` Bart Schaefer
2015-11-22 7:51 ` Bart Schaefer
2015-11-22 10:54 ` zsh 5.1.1-test-1 Sebastian Gniazdowski
2015-11-22 11:48 ` Manuel Presnitz
2015-11-22 12:23 ` Mikael Magnusson
2015-11-22 16:09 ` Peter Stephenson [this message]
2015-11-22 16:52 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151122160955.0cc6da24@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=mpy@gmx.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).