Re: Interrupt after first tabbing into a menu select clears prompt

Re: Interrupt after first tabbing into a menu select clears prompt

[Leo Mao]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

I also encounter this regression. Is there any news about this?

I can confirm that this problem only occurs when I interrupt right after
tabbing into the list.

Re: Interrupt after first tabbing into a menu select clears prompt

[Peter Stephenson]

On Fri, 15 Jan 2016 19:46:25 +0800
Leo Mao <leomao@users.sourceforge.net> wrote:
> I also encounter this regression. Is there any news about this?
> 
> I can confirm that this problem only occurs when I interrupt right after
> tabbing into the list.

It looks like this ought to help with the issue in question.
There's probably a race if you hit ^C again very quickly.

Possibly zrefresh() ought to save, reset, and finally restore the
errflag, which could help in other places.  Either that, or it
should simply refuse to redraw until the error condition is reset.

pws

diff --git a/Src/Zle/complist.c b/Src/Zle/complist.c
index 29aaee8..0ccb885 100644
--- a/Src/Zle/complist.c
+++ b/Src/Zle/complist.c
@@ -2584,6 +2584,12 @@ domenuselect(Hookdef dummy, Chdata dat)
     	if (!do_last_key) {
 	    zmult = 1;
 	    cmd = getkeycmd();
+	    /*
+	     * On interrupt, we'll exit due to cmd being empty.
+	     * Don't propagate the interrupt any further, which
+	     * can screw up redrawing.
+	     */
+	    errflag &= ~ERRFLAG_INT;
 	    if (mtab_been_reallocated) {
 		do_last_key = 1;
 		continue;

Interrupt after first tabbing into a menu select clears prompt

[Philip Sequeira]

This is a regression, been happening for a while but I never got
around to tracking it down.

>From zsh -f:
zstyle ':completion:*' menu select=0
autoload -Uz compinit
compinit
ls<Tab><Tab>^C

And the prompt disappears. As far as I can tell, it only happens if
you interrupt right after tabbing into the list, without doing
anything else. If you go to another entry, or even back to the first
one, before hitting ^C, it won't disappear.

Bisected to 32f5d3d8c16b4f3a11fa39c0ee378d72336ba853. Removing the if
(!errflag) added by that commit fixes my problem, but I guess you'll
want to add another check or something instead if you still think that
propagating an error should usually not redraw the line.