From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: ZSH_SCRIPT
Date: Thu, 03 Mar 2016 17:37:30 +0000 [thread overview]
Message-ID: <20160303173730.45a8c8ee@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <87mvqflbgh.fsf@lwm.klanderman.net>
On Thu, 3 Mar 2016 12:26:22 -0500
Greg Klanderman <gak@klanderman.net> wrote:
> Peter/Bart do you think it needs both ztrdup()s?
>
> in zsh_main():
> zsh_script = ztrdup(runscript);
>
> and in createparamtable():
> setsparam("ZSH_SCRIPT", ztrdup(zsh_script));
I think it needs the second, because what you pass to a parameter needs
to be uniquely managed by that parameter, so it can't point to memory
that can be referenced another way. I doubt it needs the first as well.
Actually, I don't see why you need a glboal for zsh_script at all. It's
just there to pass runscript on so it can be set later. That's better
done by passing arguments rather than globals.
pws
next prev parent reply other threads:[~2016-03-03 17:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 17:34 ZSH_SCRIPT Greg Klanderman
2016-02-24 22:31 ` ZSH_SCRIPT Bart Schaefer
2016-02-25 9:33 ` ZSH_SCRIPT Peter Stephenson
2016-02-25 17:59 ` ZSH_SCRIPT Greg Klanderman
2016-02-25 23:04 ` ZSH_SCRIPT Bart Schaefer
2016-02-29 23:36 ` ZSH_SCRIPT Greg Klanderman
2016-03-01 9:27 ` ZSH_SCRIPT Peter Stephenson
2016-03-01 14:39 ` ZSH_SCRIPT Greg Klanderman
2016-03-01 15:07 ` ZSH_SCRIPT Peter Stephenson
2016-03-01 16:36 ` ZSH_SCRIPT Greg Klanderman
2016-03-01 18:36 ` ZSH_SCRIPT Bart Schaefer
2016-03-01 20:14 ` ZSH_SCRIPT Greg Klanderman
2016-03-02 9:30 ` ZSH_SCRIPT Peter Stephenson
2016-03-02 15:48 ` ZSH_SCRIPT Greg Klanderman
2016-03-02 15:56 ` ZSH_SCRIPT Peter Stephenson
2016-03-02 21:33 ` ZSH_SCRIPT Greg Klanderman
2016-03-02 19:34 ` ZSH_SCRIPT Martijn Dekker
2016-03-02 21:24 ` ZSH_SCRIPT Greg Klanderman
2016-03-03 9:37 ` ZSH_SCRIPT Peter Stephenson
2016-03-03 17:26 ` ZSH_SCRIPT Greg Klanderman
2016-03-03 17:37 ` Peter Stephenson [this message]
2016-03-03 19:36 ` ZSH_SCRIPT Greg Klanderman
2016-03-03 20:39 ` ZSH_SCRIPT Peter Stephenson
2016-03-03 20:44 ` ZSH_SCRIPT Bart Schaefer
2016-03-03 20:50 ` ZSH_SCRIPT Bart Schaefer
2016-03-04 2:07 ` ZSH_SCRIPT Greg Klanderman
2016-03-05 16:22 ` ZSH_SCRIPT Bart Schaefer
2016-03-05 20:03 ` ZSH_SCRIPT Greg Klanderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303173730.45a8c8ee@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).