From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marko Myllynen <myllynen@redhat.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _virsh (Was: Re: zsh virsh completion)
Date: Wed, 20 Jul 2016 06:58:32 +0000 [thread overview]
Message-ID: <20160720065832.GA28939@tarsus.local2> (raw)
In-Reply-To: <9968da53-c1fd-fa2a-f30c-c74f884d2478@redhat.com>
Resubjecting to draw attention to your patch.
I haven't done a full review, but I did spot a couple of trivial issues:
Marko Myllynen wrote on Mon, Jul 18, 2016 at 15:06:52 +0300:
> case $service in
> virsh)
> if (( ! $+_cache_virsh_cmds )); then
> _cache_virsh_cmds=( ${${${${(f):-"$(_call_program options virsh help)"}:#*:}/# ##}/ *} )
> + for icmd in $interact_cmds; do
Need to declare $icmd local.
> + _cache_virsh_cmds[$_cache_virsh_cmds[(i)$icmd]]=()
> + done
> fi
> if (( ! $+_cache_virsh_cmdopts )); then
> typeset -gA _cache_virsh_cmdopts
> fi
> _arguments -A "-*" -C -S -s -w \
Oliver remarked on the -w earlier, are you quite sure it's correct?
-w In combination with -s, allow option stacking even if one
or more of the options take arguments. For example, if
-x takes an argument, with no -s, `-xy' is considered as
a single (unhandled) option; with -s, -xy is an option
with the argument `y'; with both -s and -w, -xy may be
the option -x and the option -y with arguments still to
come.
(-s and -w are options to _arguments, -xy is a word on the command line
being completed)
> - '(-c --connect)'{-c+,--connect}'[specify connection URI]:URI:_hosts' \
Should be {-c+,--connect=} with an equals sign?
Cheers,
Daniel
next prev parent reply other threads:[~2016-07-20 7:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 11:52 zsh virsh completion Marko Myllynen
2016-07-11 15:03 ` Roman Neuhauser
2016-07-11 16:40 ` Bart Schaefer
2016-07-11 22:07 ` Oliver Kiddle
2016-07-12 10:23 ` Marko Myllynen
2016-07-13 4:59 ` Daniel Shahaf
2016-07-18 12:06 ` Marko Myllynen
2016-07-20 6:58 ` Daniel Shahaf [this message]
2016-07-20 8:36 ` [PATCH] _virsh (Was: Re: zsh virsh completion) Marko Myllynen
2016-07-21 6:57 ` Daniel Shahaf
2016-07-21 12:32 ` Marko Myllynen
2016-07-22 6:30 ` Daniel Shahaf
2016-07-22 8:17 ` Marko Myllynen
2016-07-21 16:12 ` Oliver Kiddle
2016-07-21 16:19 ` Marko Myllynen
2016-07-22 7:19 ` Daniel Shahaf
2016-08-31 21:15 ` Oliver Kiddle
2016-09-02 5:23 ` Daniel Shahaf
2016-09-02 15:02 ` Oliver Kiddle
2016-09-04 4:01 ` Daniel Shahaf
2016-09-07 6:39 ` Bart Schaefer
2016-09-09 22:09 ` Oliver Kiddle
2016-09-11 9:08 ` Daniel Shahaf
2016-09-14 23:19 ` Oliver Kiddle
2016-09-04 21:24 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720065832.GA28939@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=myllynen@redhat.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).