zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _virsh (Was: Re: zsh virsh completion)
Date: Tue, 6 Sep 2016 23:39:01 -0700	[thread overview]
Message-ID: <160906233901.ZM11422@torch.brasslantern.com> (raw)
In-Reply-To: <20160904040142.GA5216@fujitsu.shahaf.local2>

On Sep 4,  4:01am, Daniel Shahaf wrote:
}
} Perhaps using sudo should be opt-in on the part of the user; that is:
} when gain-privileges is unset, either behave as though it's set to
} false, or perhaps prompt the user (via the minibuffer?) for permission
} to use sudo.  (And cache the user's reply for next time?)
} 
} Just thinking out loud here.

I haven't been paying a whole lot of attention to this thread because
Oliver seemed to have it pretty well surrounded, but my two cents:

I would prefer that we never implicitly call 'sudo'; rather, that it
be explictly referenced by the user in a zstyle whether or not it's
already on the command line.

There's an admittedly somewhat arbitrary line between a completion
being helpful enough, and it venturing into places it has no business
going in an effort to present perfect knowledge.  Sometimes perfect
knowledge isn't worth the effort or the side-effects.  (A lot of the
"remote" completions are bumping along this line as well.)

However, I also think prompting during completion (except in the form
of the menu-ing variations) is likely to cause mistakes.


  reply	other threads:[~2016-09-07  6:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 11:52 zsh virsh completion Marko Myllynen
2016-07-11 15:03 ` Roman Neuhauser
2016-07-11 16:40 ` Bart Schaefer
2016-07-11 22:07 ` Oliver Kiddle
2016-07-12 10:23   ` Marko Myllynen
2016-07-13  4:59 ` Daniel Shahaf
2016-07-18 12:06   ` Marko Myllynen
2016-07-20  6:58     ` [PATCH] _virsh (Was: Re: zsh virsh completion) Daniel Shahaf
2016-07-20  8:36       ` Marko Myllynen
2016-07-21  6:57         ` Daniel Shahaf
2016-07-21 12:32           ` Marko Myllynen
2016-07-22  6:30             ` Daniel Shahaf
2016-07-22  8:17               ` Marko Myllynen
2016-07-21 16:12         ` Oliver Kiddle
2016-07-21 16:19           ` Marko Myllynen
2016-07-22  7:19           ` Daniel Shahaf
2016-08-31 21:15             ` Oliver Kiddle
2016-09-02  5:23               ` Daniel Shahaf
2016-09-02 15:02                 ` Oliver Kiddle
2016-09-04  4:01                   ` Daniel Shahaf
2016-09-07  6:39                     ` Bart Schaefer [this message]
2016-09-09 22:09                       ` Oliver Kiddle
2016-09-11  9:08                         ` Daniel Shahaf
2016-09-14 23:19                     ` Oliver Kiddle
2016-09-04 21:24                   ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160906233901.ZM11422@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).