From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH 3(b)/3] _man: Support _correct_word.
Date: Thu, 04 Aug 2016 21:47:28 +0000 [thread overview]
Message-ID: <20160804214728.GA12562@tarsus.local2> (raw)
In-Reply-To: <CAH+w=7ayiaObcLHxZ6m7Ztj4Kzgm3mjvb0JywpCWcHYyJjQSSQ@mail.gmail.com>
Bart Schaefer wrote on Thu, Aug 04, 2016 at 09:28:44 -0700:
> On Thu, Aug 4, 2016 at 9:08 AM, Peter Stephenson
> <p.stephenson@samsung.com> wrote:
> > On Thu, 4 Aug 2016 15:54:26 +0000
> > Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >> Since compfiles is undocumented, avoid its use altogether, replacing it by
> >> a construct that blackbox analysis suggests to be equivalent.
> >
> > This is likely to be saner, if it works.
>
> I'll just point out that this proposed change means that _man_pages no
> longer accepts the -M argument to add a matcher spec.
Might you have misread the diff?
Before this patch, -M was handled twice: both by the zparseopts call and
by compadd. With this patch, -M is only handled by compadd.
Empirically, matchspecs are honoured:
% zstyle :completion:\* matcher-list '' "r:|::=* r:|=*"
% man X::L::Pat<TAB>
<becomes>
% man XML::Lib::Pattern
I tried to clarify this in the log message.
Cheers,
Daniel
prev parent reply other threads:[~2016-08-04 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 15:54 [PATCH 0/3] A set of _man fixes — explanation for 3(a)/3 and 3(b)/3 Daniel Shahaf
2016-08-04 15:54 ` [PATCH 1/3] _man: Drop (b): it's incorrect when $sect contains '|' Daniel Shahaf
2016-08-04 15:54 ` [PATCH 2/3] _man: Fix two bugs when completing manpage filenames in separate-sections mode Daniel Shahaf
2016-08-04 15:54 ` [PATCH 3(a)/3] _man: Support _correct_word Daniel Shahaf
2016-08-04 15:54 ` [PATCH 3(b)/3] " Daniel Shahaf
2016-08-04 16:08 ` Peter Stephenson
2016-08-04 16:28 ` Bart Schaefer
2016-08-04 19:54 ` Bart Schaefer
2016-08-04 21:47 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804214728.GA12562@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).