zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: zsh/re2 : avoid until further notice
Date: Wed, 14 Sep 2016 18:47:17 +0000	[thread overview]
Message-ID: <20160914184717.GA9187@tower.spodhuis.org> (raw)
In-Reply-To: <20160912035025.GA32028@fujitsu.shahaf.local2>

On 2016-09-12 at 03:50 +0000, Daniel Shahaf wrote:
> A comma is missing after the first "yes":
> 
> +  AC_TRY_RUN([
> ⋮
> +}],
> +  zsh_cv_cre2_runtime_broken=no,
> +  zsh_cv_cre2_runtime_broken=yes
> +  zsh_cv_cre2_runtime_broken=yes))

*facepalm*

Thank you.

diff --git a/configure.ac b/configure.ac
index c000d6a..f055583 100644
--- a/configure.ac
+++ b/configure.ac
@@ -718,8 +718,8 @@ int main(int argc, char **argv) {
        return 0;
 }],
   zsh_cv_cre2_runtime_broken=no,
-  zsh_cv_cre2_runtime_broken=yes
-  zsh_cv_cre2_runtime_broken=yes))
+  zsh_cv_cre2_runtime_broken=yes,
+  zsh_cv_cre2_runtime_broken=unknown))
   if test x$zsh_cv_cre2_runtime_broken = xyes; then
     AC_MSG_ERROR([cre2 library hard-unusable, rebuild with same compiler as for RE2])
   fi


      reply	other threads:[~2016-09-14 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08  4:15 [PATCH] Add zsh/re2 module with conditions Phil Pennock
2016-09-08 13:56 ` [PATCH] re2: fix clean-up path; fix two comments Phil Pennock
2016-09-08 21:14 ` [PATCH] Add zsh/re2 module with conditions Oliver Kiddle
2016-09-08 21:48   ` Phil Pennock
     [not found] ` <20160908144203.GA28545@fujitsu.shahaf.local2>
     [not found]   ` <20160908204737.GA12164@breadbox.private.spodhuis.org>
     [not found]     ` <20160908211643.GA4432@fujitsu.shahaf.local2>
     [not found]       ` <20160909005557.GB12371@breadbox.private.spodhuis.org>
     [not found]         ` <20160909045739.GA6623@fujitsu.shahaf.local2>
     [not found]           ` <20160910010456.GA85981@tower.spodhuis.org>
     [not found]             ` <20160910190924.GB4045@fujitsu.shahaf.local2>
2016-09-11 19:23               ` zsh/re2 : avoid until further notice Phil Pennock
2016-09-11 19:27                 ` Phil Pennock
2016-09-12  3:50                 ` Daniel Shahaf
2016-09-14 18:47                   ` Phil Pennock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914184717.GA9187@tower.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).