From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Bug related to stdin/always/jobcontrol
Date: Thu, 22 Sep 2016 11:59:21 +0000 [thread overview]
Message-ID: <20160922115921.GA3613@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20160914223553.3173c8ca@ntlworld.com>
Peter Stephenson wrote on Wed, Sep 14, 2016 at 22:35:53 +0100:
> On Wed, 14 Sep 2016 18:31:05 +0100
> Peter Stephenson <p.stephenson@samsung.com> wrote:
> > I think I might be getting close with the attached patch... first
> > guess is we need to create a new process group, or something.
>
> The subjob needs to keep its process group because it's too late to
> change it; I found out what was missing, it needs process group leader
> assigning from that of list_pipe_job (obviously, right?) Seems a bit
> weird this never got noticed before, but it's hard to see how it can be
> wrong since this is the way the pipeline always works, regardless of
> whether the ls process or equivalent has exited. I've tried a few bits
> of job control with multiple different list-pipe-style constructs lying
> around and they still seem to work.
This (39331) broke fg'ing a function for me:
% print $ZSH_PATCHLEVEL
zsh-5.2-dev-1-401-g4e51079
% f() { $EDITOR }
% f
<press ^Z in the editor>
zsh: suspended f
% fg
[1] + continued f
zsh: suspended (tty output) f
After the 'fg' I get another prompt immediately, instead of being
returend to $EDITOR.
Cheers,
Daniel
next prev parent reply other threads:[~2016-09-22 12:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 18:39 Christian Neukirchen
2016-09-05 15:04 ` Christian Neukirchen
2016-09-05 15:42 ` Peter Stephenson
[not found] ` <CGME20160914173110eucas1p1f0567e319ae439b975b19f4e55676fed@eucas1p1.samsung.com>
2016-09-14 17:31 ` Peter Stephenson
2016-09-14 21:35 ` Peter Stephenson
2016-09-15 3:24 ` Bart Schaefer
2016-09-15 8:27 ` Peter Stephenson
2016-09-15 10:33 ` Peter Stephenson
2016-09-15 17:40 ` Peter Stephenson
2016-09-16 1:08 ` Bart Schaefer
2016-09-16 12:02 ` Peter Stephenson
2016-09-22 11:59 ` Daniel Shahaf [this message]
2016-09-22 16:38 ` Bart Schaefer
2016-09-23 1:18 ` Bart Schaefer
2016-09-23 6:06 ` Daniel Shahaf
2016-09-25 14:39 ` Peter Stephenson
2016-09-25 22:54 ` struct job.other (was Re: Bug related to stdin/always/jobcontrol) Bart Schaefer
2016-09-26 11:20 ` Peter Stephenson
2016-09-26 16:33 ` Bart Schaefer
2016-09-25 15:16 ` Bug related to stdin/always/jobcontrol Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922115921.GA3613@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).