zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Cc: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Subject: type-checking for metafiedness?  (was: Re: Cores almost on demand in patcompile())
Date: Tue, 11 Oct 2016 06:51:05 +0000	[thread overview]
Message-ID: <20161011065105.GB16819@fujitsu.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7a7jc0Q2=M9aG5mttbazxfsHB-Cz=WwJzCvz_SdnbApRw@mail.gmail.com>

Bart Schaefer wrote on Mon, Oct 10, 2016 at 19:46:18 -0700:
> The comments say that this argument is expected to be metafied
> (pattern.c 522), but as best I can tell it's passed down from
> paramsubst() tokenized but not metafied.

Pardon me if this has been discussed before, but why don't we introduce
the type definitions
.
    struct metafied_t { char *v; };
    struct unmetafied_t { char *v; };
.
and start incrementally replacing uses of "char *" with uses of these
types?  This will gain type checking for metafied v. unmetafied strings,
as these two types do not implicitly convert into each other (attempts
to do so generate a compiler warning).

Cheers,

Daniel


  parent reply	other threads:[~2016-10-11  6:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09  9:00 Cores almost on demand in patcompile() Sebastian Gniazdowski
2016-10-09  9:16 ` Sebastian Gniazdowski
2016-10-09 10:15   ` Sebastian Gniazdowski
2016-10-09 16:09     ` Sebastian Gniazdowski
2016-10-10 15:31       ` Sebastian Gniazdowski
2016-10-11  2:46         ` Bart Schaefer
2016-10-11  2:53           ` Bart Schaefer
2016-10-11  6:51           ` Daniel Shahaf [this message]
2016-10-13 10:22             ` type-checking for metafiedness? (was: Re: Cores almost on demand in patcompile()) Peter Stephenson
2016-10-13 13:46               ` Bart Schaefer
2016-10-14  6:36                 ` Daniel Shahaf
2016-10-14 16:53                   ` Peter Stephenson
2016-10-14 17:28                     ` Bart Schaefer
2016-10-14 20:08                     ` Daniel Shahaf
2016-10-14 23:04                   ` Oliver Kiddle
2016-10-15  8:30                     ` Daniel Shahaf
     [not found]                       ` <CAH+w=7bONQfKge=kWwFasKNXSu7510d8c+1aoYEeyUbozf_P7A@mail.gmail.com>
2016-10-15 18:35                         ` Fwd: " Bart Schaefer
2016-10-13  9:43           ` Cores almost on demand in patcompile() Peter Stephenson
2016-10-19 11:14             ` Sebastian Gniazdowski
2016-10-19 13:14               ` Peter Stephenson
     [not found]                 ` <CAKc7PVBhHFUWbMobAeDptgXmZ=S6RVsuNB7Qwsq555Srya_5qg@mail.gmail.com>
2016-10-20  8:56                   ` Bart Schaefer
2016-10-20  9:32                   ` Peter Stephenson
2016-10-20  9:56                     ` Sebastian Gniazdowski
2016-10-20 10:18                       ` Peter Stephenson
2016-10-20 10:30                         ` Sebastian Gniazdowski
2016-10-20 10:42                           ` Peter Stephenson
2016-10-20 10:56                             ` Peter Stephenson
2016-10-20 11:03                               ` Peter Stephenson
2016-10-20 11:09                                 ` Sebastian Gniazdowski
2016-10-20 11:23                                   ` Peter Stephenson
     [not found] <CGME20161016014741eucas1p189be6c2fa19aaf9d31733cae5f716178@eucas1p1.samsung.com>
2016-10-16  1:14 ` type-checking for metafiedness? (was: Re: Cores almost on demand in patcompile()) Bart Schaefer
2016-10-16 17:03   ` Daniel Shahaf
2016-10-18 11:36   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011065105.GB16819@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).