From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Cores almost on demand in patcompile()
Date: Thu, 20 Oct 2016 12:23:18 +0100 [thread overview]
Message-ID: <20161020122318.136c6ae4@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAKc7PVChVhhSVbu1-6rvTjbz9rRjms2qjAaMe2ROFXWodA54qw@mail.gmail.com>
On Thu, 20 Oct 2016 13:09:25 +0200
Sebastian Gniazdowski <sgniazdowski@gmail.com> wrote:
> Tested the change, no segfault, also when break is added to unmodified
> code. Also checked if the pattern still matches (made use of the
> prepared input1.txt, input2.txt) and it does, in both versions.
Thanks.
I think that *is* the correct fix --- we add PAT_PURES to the flag that
will later be used when we run the pattern, and in that case any of the
usual wordcode infrastructure is irrelevant because we do indeed treat
it just as a single (metafied :-() string. So breaking out of the loop
immediately is the right thing to do.
pws
prev parent reply other threads:[~2016-10-20 11:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 9:00 Sebastian Gniazdowski
2016-10-09 9:16 ` Sebastian Gniazdowski
2016-10-09 10:15 ` Sebastian Gniazdowski
2016-10-09 16:09 ` Sebastian Gniazdowski
2016-10-10 15:31 ` Sebastian Gniazdowski
2016-10-11 2:46 ` Bart Schaefer
2016-10-11 2:53 ` Bart Schaefer
2016-10-11 6:51 ` type-checking for metafiedness? (was: Re: Cores almost on demand in patcompile()) Daniel Shahaf
2016-10-13 10:22 ` Peter Stephenson
2016-10-13 13:46 ` Bart Schaefer
2016-10-14 6:36 ` Daniel Shahaf
2016-10-14 16:53 ` Peter Stephenson
2016-10-14 17:28 ` Bart Schaefer
2016-10-14 20:08 ` Daniel Shahaf
2016-10-14 23:04 ` Oliver Kiddle
2016-10-15 8:30 ` Daniel Shahaf
[not found] ` <CAH+w=7bONQfKge=kWwFasKNXSu7510d8c+1aoYEeyUbozf_P7A@mail.gmail.com>
2016-10-15 18:35 ` Fwd: " Bart Schaefer
2016-10-13 9:43 ` Cores almost on demand in patcompile() Peter Stephenson
2016-10-19 11:14 ` Sebastian Gniazdowski
2016-10-19 13:14 ` Peter Stephenson
[not found] ` <CAKc7PVBhHFUWbMobAeDptgXmZ=S6RVsuNB7Qwsq555Srya_5qg@mail.gmail.com>
2016-10-20 8:56 ` Bart Schaefer
2016-10-20 9:32 ` Peter Stephenson
2016-10-20 9:56 ` Sebastian Gniazdowski
2016-10-20 10:18 ` Peter Stephenson
2016-10-20 10:30 ` Sebastian Gniazdowski
2016-10-20 10:42 ` Peter Stephenson
2016-10-20 10:56 ` Peter Stephenson
2016-10-20 11:03 ` Peter Stephenson
2016-10-20 11:09 ` Sebastian Gniazdowski
2016-10-20 11:23 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020122318.136c6ae4@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).