Re: Possible huge setarrvalue optimization

[Peter Stephenson <p.w.stephenson@ntlworld.com>]

On Sun, 20 Nov 2016 09:41:48 -0800
> This and the proposed getstr optimization both make me nervous.  I know
> Sebastian is anxious to have them appear in the next release, but it feels
> and if we should have more time using them in dev branches.

I pushed the string setting change with my tweak since it looked like it
ought to cover all possible cases sensibly.

Given what Sebastian says, we probably ought to suspend optimisations at
this point for now.

I intend to release 5.3 before Christmas come hell or high water, well,
unless it's very high, since there's plenty to get out.

pws

From zsh-workers-return-39998-mason-zsh=primenet.com.au@zsh.org Wed Nov 23 21:22:22 2016
Return-Path: <zsh-workers-return-39998-mason-zsh=primenet.com.au@zsh.org>
Delivered-To: mason-zsh@primenet.com.au
Received: (qmail 13220 invoked by alias); 23 Nov 2016 21:22:22 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
Delivered-To: mailing list zsh-workers@zsh.org
X-Seq: 39998
Received: (qmail 23583 invoked from network); 21 Nov 2016 13:46:32 -0000
X-Qmail-Scanner-Diagnostics: from mx0b-001b2d01.pphosted.com by f.primenet.com.au (envelope-from <hanpt@linux.vnet.ibm.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(148.163.158.5):SA:0(1.1/5.0):. 
 Processed in 0.678458 secs); 21 Nov 2016 13:46:32 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: *
X-Spam-Status: No, score=1.1 required=5.0 tests=LONGWORDS,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H2 autolearn=no autolearn_force=no version=3.4.1
X-Envelope-From: hanpt@linux.vnet.ibm.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at linux.vnet.ibm.com does not designate permitted sender hosts)
Date: Mon, 21 Nov 2016 14:50:05 +0800
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: zsh-workers@zsh.org
Subject: Re: Remind me why ${name+word} is the way it is?
Mail-Followup-To: zsh-workers@zsh.org
References: <161111203400.ZM31567@torch.brasslantern.com>
 <20161117023325.GA3324@localhost.localdomain>
 <CAH+w=7YbPRhK1Mw0P7DKObaYU2vXCuECUGkvwp1d2R4K0dC7CA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH+w=7YbPRhK1Mw0P7DKObaYU2vXCuECUGkvwp1d2R4K0dC7CA@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-TM-AS-GCONF: 00
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16112106-0020-0000-0000-00000A4DB370
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00006115; HX=3.00000240; KW=3.00000007;
 PH=3.00000004; SC=3.00000189; SDB=6.00783291; UDB=6.00378249; IPR=6.00560910;
 BA=6.00004896; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013389; XFM=3.00000011;
 UTC=2016-11-21 06:50:18
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 16112106-0021-0000-0000-000057708245
Message-Id: <20161121065005.GA4619@localhost.localdomain>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-21_05:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000
 definitions=main-1611210122

On Wed, Nov 16, 2016 at 09:34:32PM -0800, Bart Schaefer wrote:
> On Wed, Nov 16, 2016 at 6:33 PM, Han Pingtian <hanpt@linux.vnet.ibm.com> wrote:
> >
> > % name=a;echo ${name:+foo[bar]}
> > zsh: no match
> > %
> > url-quote-magic:10: no match
> 
Oh, I can still reproduce this problem by running 

    name=a;echo ${name:+foo[bar]}

two times.
> What zsh version are you using?  I can't reproduce this (tried 5.2 and
> git HEAD).
> 

I am using git HEAD, this problem can be reprodced.

> Line 10 is
> 
> words=("${(@Q)${(z)lbuf}}")
> 
> To get the "no match" message you have to have cshnullglob set, and
> obviously you also have self-insert remapped to url-quote-magic.  I
> suspect you have another setting that is influencing this.

Yes, I have cshnullglob set and self-insert remapped. If I unset
cshnullglob, then this problem cannot be reproduced any more.

Those are all the options:

% setopt
autocd
autopushd
nobgnice
braceccl
completeinword
cshnullglob
extendedglob
extendedhistory
noglobalrcs
globcomplete
histexpiredupsfirst
histfindnodups
histignorespace
histlexwords
histsavenodups
histverify
incappendhistorytime
interactive
interactivecomments
kshtypeset
nolistambiguous
magicequalsubst
monitor
pushdignoredups
rcexpandparam
rcquotes
rmstarwait
shinstdin
zle

Thanks.