From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Sebastian Gniazdowski <psprint@protonmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Possible huge setarrvalue optimization
Date: Thu, 5 Jan 2017 15:47:18 +0000 [thread overview]
Message-ID: <20170105154718.GA8039@fujitsu.shahaf.local2> (raw)
In-Reply-To: <eg2Qn-8P7gkBVQ43PNdGN_5vnm4oKorLtHBRokgzoF5vnVr0Cbb9sSUA7FivOJFZjx8XioCV9sPEqpI2VYIliEuiedHSRfehTSB45R_ugoQ=@protonmail.com>
Sebastian Gniazdowski wrote on Thu, Jan 05, 2017 at 08:32:25 -0500:
> Unless auto-exported parameters are marked as special (and it's rather
> not the case), the point is that current code will miss environment
> update on parameter update.
Like I said, I added an 'ename == NULL' check when I pushed. The code
in tip of master reads:
if (pre_assignment_length == post_assignment_length
&& v->pm->gsu.a->setfn == arrsetfn
/* ... and isn't something that arrsetfn() treats specially */
&& 0 == (v->pm->node.flags & (PM_SPECIAL|PM_UNIQUE))
&& NULL == v->pm->ename)
Is that still wrong in some way?
prev parent reply other threads:[~2017-01-05 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 6:17 Sebastian Gniazdowski
2016-11-18 7:09 ` Sebastian Gniazdowski
2016-11-18 9:32 ` Sebastian Gniazdowski
2016-11-18 12:20 ` Sebastian Gniazdowski
2016-11-20 11:46 ` Daniel Shahaf
2016-11-20 17:41 ` Bart Schaefer
2016-11-20 20:54 ` Sebastian Gniazdowski
2016-11-20 21:19 ` Peter Stephenson
2016-12-24 17:19 ` Daniel Shahaf
2017-01-04 18:31 ` Sebastian Gniazdowski
2017-01-05 4:13 ` Daniel Shahaf
2017-01-05 13:32 ` Sebastian Gniazdowski
2017-01-05 15:47 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105154718.GA8039@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=psprint@protonmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).