From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] [RFC] Get subject of current patch in rebase-apply mode
Date: Tue, 22 Nov 2016 04:13:48 +0000 [thread overview]
Message-ID: <20161122041348.GA21742@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20161120013325.12113-2-genml+zsh-workers@thequod.de>
Daniel Hahler wrote on Sun, Nov 20, 2016 at 02:33:25 +0100:
> From: Daniel Hahler <git@thequod.de>
>
> ---
> Functions/VCS_Info/Backends/VCS_INFO_get_data_git | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Functions/VCS_Info/Backends/VCS_INFO_get_data_git b/Functions/VCS_Info/Backends/VCS_INFO_get_data_git
> index 18ba89a..93172fc 100644
> --- a/Functions/VCS_Info/Backends/VCS_INFO_get_data_git
> +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_git
> @@ -236,6 +236,15 @@ elif [[ -d "${gitdir}/rebase-apply" ]]; then
> done
> if [[ -f "${patchdir}/msg-clean" ]]; then
> subject="${$(< "${patchdir}/msg-clean")[(f)1]}"
I use an older version of git that still creates msg-clean files (see
36830), so I rm'd the msg-clean file by hand to test your patch.
> + else
> + local maxlines=10
> + while IFS='\n' read -r; do
Change '\n' to $'\n'. (But read the last paragraph first.)
> + if [[ "$REPLY" == "Subject:"* ]]; then
> + subject=${REPLY/(#s)Subject: /}
> + break
> + fi
> + (( --maxlines )) || break
> + done < "${patchdir}/$(printf "%04d" $cur)"
I'm not an expert on git internal data structures, but I see two failure
modes to this patch: the file "$patchdir/${(l:4::0:)cur}" might not
exist, or might correspond to a different commit than $cur. The former
case could be addressed by adding a [[ -f ]] existence check, as
elsewhere in the file. The latter would cause information for a wrong
commit to be printed instead of a commit hash. That would be a bug, but
it seems unlikely enough.
So I would suggest two code changes: use «${(l:4::0:)cur}» or the new
'printf -v' instead of a command substitution to save a fork on Cygwin,
and consider adding a [[ -f ]] check to prevent error messages.
One last thing I'd suggest is to consider using VCS_INFO_quilt-patch2subject,
since it implements rfc822 unfolding of long subject lines.
Cheers,
Daniel
> fi
> if [[ -f "${patchdir}/original-commit" ]]; then
> if [[ -n $subject ]]; then
> --
> 2.10.2
>
>
next prev parent reply other threads:[~2016-11-23 21:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161120013325.12113-1-genml+zsh-workers@thequod.de>
2016-11-20 1:33 ` Daniel Hahler
2016-11-20 1:43 ` Daniel Hahler
2016-11-21 0:16 ` Frank Terbeck
2016-11-22 4:13 ` Daniel Shahaf [this message]
2016-11-28 22:59 ` Daniel Hahler
2016-11-29 6:15 ` Daniel Shahaf
2016-12-02 23:20 ` Daniel Hahler
2016-12-03 10:34 ` [PATCH] vcs_info git: rfc822-unfold rebase-apply patch subjects when msg-clean is unavailable Daniel Shahaf
2016-12-01 17:28 ` [PATCH] [RFC] Get subject of current patch in rebase-apply mode Daniel Shahaf
2016-11-28 22:56 ` [PATCH] fixup! " Daniel Hahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122041348.GA21742@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).