zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] [RFC] Get subject of current patch in rebase-apply mode
Date: Mon, 21 Nov 2016 01:16:18 +0100	[thread overview]
Message-ID: <87fumlznzh.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20161120013325.12113-2-genml+zsh-workers@thequod.de> (Daniel Hahler's message of "Sun, 20 Nov 2016 02:33:25 +0100")

Hi,

I'd use a named local parameter instead of REPLY and clear out IFS
completely:

Daniel Hahler wrote:
> +            local maxlines=10
> +            while IFS='\n' read -r;  do

               local maxlines=10 line
               while IFS= read -r line;  do

…and then use $line instead of $REPLY in the rest.


Regards, Frank


  parent reply	other threads:[~2016-11-23 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161120013325.12113-1-genml+zsh-workers@thequod.de>
2016-11-20  1:33 ` Daniel Hahler
2016-11-20  1:43   ` Daniel Hahler
2016-11-21  0:16   ` Frank Terbeck [this message]
2016-11-22  4:13   ` Daniel Shahaf
2016-11-28 22:59     ` Daniel Hahler
2016-11-29  6:15       ` Daniel Shahaf
2016-12-02 23:20         ` Daniel Hahler
2016-12-03 10:34           ` [PATCH] vcs_info git: rfc822-unfold rebase-apply patch subjects when msg-clean is unavailable Daniel Shahaf
2016-12-01 17:28       ` [PATCH] [RFC] Get subject of current patch in rebase-apply mode Daniel Shahaf
2016-11-28 22:56   ` [PATCH] fixup! " Daniel Hahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fumlznzh.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=genml+zsh-workers@thequod.de \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).