zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Laurent Arnoud <laurent@spkdev.net>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add missing commands to Debian apt completion
Date: Fri, 25 Nov 2016 16:59:13 +0000	[thread overview]
Message-ID: <20161125165913.GA10717@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20161125161905.6jqtkq2arphofrat@spk-laptop>

Laurent Arnoud wrote on Fri, Nov 25, 2016 at 17:19:05 +0100:
> On Fri, Nov 25, 2016 at 09:35:51AM +0000, Daniel Shahaf wrote:
> > Laurent Arnoud wrote on Tue, Nov 22, 2016 at 19:31:37 +0100:
> > > +++ b/Completion/Debian/Command/_apt
> > > @@ -402,17 +402,29 @@ _apt-cmd () {
> > >      /$'show\0'/ /$'[^\0]#\0'/ ':packages::_deb_packages "$expl_packages[@]" avail' \# \
> > > +    /$'showsrc\0'/ /$'[^\0]#\0'/ ':packages::_deb_packages "$expl_packages[@]" avail' \# \| \
> > 
> > I had to move the 'showsrc' line to above the 'show' line for «apt
> > showsrc <TAB>» to work.  Is this expected, or a bug in _apt_arguments
> > or _regex_arguments?
> 
> Yes you are right, I'm not sure about the bug but it is done like that in
> `_apt-cache` function. I will just do as you did since I'm not an expert with
> this.

Actually, I looked again and a «\|» is missing from the 'list' and
'show' lines.  I'll push your new patch with this modification.  Thanks
for the patch!


  reply	other threads:[~2016-11-25 17:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 18:31 Laurent Arnoud
2016-11-25  9:35 ` Daniel Shahaf
2016-11-25 16:19   ` Laurent Arnoud
2016-11-25 16:59     ` Daniel Shahaf [this message]
2016-11-25 16:23   ` Laurent Arnoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161125165913.GA10717@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=laurent@spkdev.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).