Re: [patch] minor patch to remove duplicates

[Daniel Shahaf <d.s@daniel.shahaf.name>]

Eitan Adler wrote on Mon, Nov 28, 2016 at 22:53:24 -0800:
> +++ b/Src/input.c
> @@ -51,7 +51,7 @@
>   * Note that the input string is itself used as the input buffer: it is not
>   * copied, nor is it every written back to, so using a constant string
>   * should work.  Consequently, when passing areas of memory from the heap
> - * it is necessary that that heap last as long as the operation of reading
> + * it is necessary that the heap last as long as the operation of reading

The patch changed the meaning of this sentence.  Wasn't the sentence
more accurate before the patch?

(To be clear — the sentence was grammatical not only after but also
before the patch.)

>   * the string.  After the string is read, the stack should be popped with
>   * inpop(), which effectively flushes any unread input as well as restoring
>   * the previous input state.


> +++ b/Doc/Zsh/compsys.yo
> @@ -144,8 +144,8 @@ directory mentioned in the tt(fpath) parameter, and should be autoloaded
>  few utility functions, arrange for all the necessary shell functions to be
>  autoloaded, and will then re-define all widgets that do completion to use the
>  new system.  If you use the tt(menu-select) widget, which is part of the
> -tt(zsh/complist) module, you should make sure that that module is loaded
> -before the call to tt(compinit) so that that widget is also
> +tt(zsh/complist) module, you should make sure that the module is loaded
> +before the call to tt(compinit) so that the widget is also
>  re-defined.  If completion styles (see below) are set up to perform
>  expansion as well as completion by default, and the TAB key is bound to
>  tt(expand-or-complete), tt(compinit) will rebind it to tt(complete-word);

Cheers,

Daniel