From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: UTF-8 locales on BSDs do not support collation correctly
Date: Thu, 26 Jan 2017 17:57:17 +0000 [thread overview]
Message-ID: <20170126175717.0b5c87c1@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAHYJk3SYjNM1jDmzvhOOm7sTGTSkKg+ws8RkqRbeR3z=qeKTuw@mail.gmail.com>
On Wed, 25 Jan 2017 19:02:29 +0100
Mikael Magnusson <mikachu@gmail.com> wrote:
> It works fine on OpenBSD. However, I had to revert 40333 for it to
> compile there. Adding some extra CCs since the mailing list probably
> still doesn't work.
>
> gmake[2]: Entering directory '/home/mikachu/code/zsh/Src'
> gcc -c -I. -I../Src -I../Src -I../Src/Zle -I. -DHAVE_CONFIG_H -Wall
> -Wmissing-prototypes -O2 -o watch.o watch.c
> watch.c: In function 'readwtab':
> watch.c:488: warning: implicit declaration of function 'setutent'
> watch.c:489: warning: implicit declaration of function 'getutent'
> watch.c:489: warning: assignment makes pointer from integer without a cast
> watch.c:512: warning: implicit declaration of function 'endutent'
>...
> watch.c:(.text+0x43): undefined reference to `setutent'
> watch.c:(.text+0x48): undefined reference to `getutent'
> watch.c:(.text+0x73): undefined reference to `getutent'
> watch.c:(.text+0x83): undefined reference to `endutent'
This is obscure: the preprocessor appears to be both replacing and not
replacing getutent and setutent. I wonder if they are already
definitions that are being stomped on? Or the code should go
through a different branch entirely?
Evidently this is going to stay broken until someone with access to
OpenBSD looks at it.
(I will supply a patch that checks for setutxent etc., now I've noticed
there aren't any yet, but that doesn't appear to be the problem here,
modulo obscurities.)
pws
next prev parent reply other threads:[~2017-01-26 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 14:27 Jun T.
2017-01-25 18:02 ` Mikael Magnusson
2017-01-26 17:57 ` Peter Stephenson [this message]
2017-01-26 19:30 ` Jens Elkner
2017-01-27 9:41 ` Peter Stephenson
2017-01-28 20:26 ` Bart Schaefer
2017-01-28 20:42 ` Peter Stephenson
2017-01-28 23:27 ` Bart Schaefer
2017-01-30 10:46 ` Peter Stephenson
2017-01-30 3:59 ` Bart Schaefer
2017-01-30 9:49 ` Peter Stephenson
2017-01-31 10:09 ` Jun T.
2017-01-31 11:19 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126175717.0b5c87c1@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).