From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: UTF-8 locales on BSDs do not support collation correctly
Date: Sat, 28 Jan 2017 20:42:53 +0000 [thread overview]
Message-ID: <20170128204253.0311256d@ntlworld.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1701281225400.4560@toltec.zanshin.com>
On Sat, 28 Jan 2017 12:26:30 -0800 (PST)
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Fri, 27 Jan 2017, Peter Stephenson wrote:
>
> > On Thu, 26 Jan 2017 17:57:17 +0000
> > Peter Stephenson <p.stephenson@samsung.com> wrote:
> > > (I will supply a patch that checks for setutxent etc., now I've noticed
> > > there aren't any yet, but that doesn't appear to be the problem here,
> > > modulo obscurities.)
> >
> > Can't see any reason not to commit it anyway.
>
> I'm now getting
>
> Src/watch.c: In function `readwtab':
> Src/watch.c:497: warning: assignment from incompatible pointer type
>
>
> That's:
>
> while ((tmp = getutent()) != NULL) {
I'm not. This appears to be another system specific issue that needs to
be investigated by whoever is able. It could be compiler specific, I
suppose, but that's a basic enough error it doesn't seem likely.
As all I've done is not use functions that aren't present,
this suggests a pre-existing problem. I guess this is similar to
Michael's problem?
Just to be clear (hope this doesn't seem rude, I just don't want anyone
making untoward assumptions): I am not going to do anything at all to
investigate errors I'm not seeing myself. The orignal patch is clearly
warranted (as the feature was not working at all on a number of
systems), so unless someone does investigate the problems they are seeing,
this will simply not get fixed.
If the original code *was* working, introducing an appropriate #ifdef is
an appropriate fix. (But I am *still* not going to do the guesswork
myself as I don't know whether that's the right thing to do or not.)
As this is obviously a system-dependent minefield, it would really
help if we could identify owners for problem on the various systems
involved.
pws
next prev parent reply other threads:[~2017-01-28 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 14:27 Jun T.
2017-01-25 18:02 ` Mikael Magnusson
2017-01-26 17:57 ` Peter Stephenson
2017-01-26 19:30 ` Jens Elkner
2017-01-27 9:41 ` Peter Stephenson
2017-01-28 20:26 ` Bart Schaefer
2017-01-28 20:42 ` Peter Stephenson [this message]
2017-01-28 23:27 ` Bart Schaefer
2017-01-30 10:46 ` Peter Stephenson
2017-01-30 3:59 ` Bart Schaefer
2017-01-30 9:49 ` Peter Stephenson
2017-01-31 10:09 ` Jun T.
2017-01-31 11:19 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128204253.0311256d@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).