Re: Skipping gdbm test

[Daniel Shahaf <d.s@daniel.shahaf.name>]

Peter Stephenson wrote on Fri, Mar 03, 2017 at 09:19:02 +0000:
> On Thu, 02 Mar 2017 08:17:44 -0800
> Sebastian Gniazdowski <psprint3@fastmail.com> wrote:
> > Maybe the skip could be done more quiet? I've followed V10private.tst,
> > but that module is easily built. Checked that in %prep path to gdbm
> > module file is: Modules/zsh/db/gdbm.so
> 
> I don't think it's a problem.  Skipping is common within tests, too,
> depending on system features.  It's just when something changes that
> people notice.

I think the proposal was to removal lines 2,3 but keep lines 1,4:

>>>>      1 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
>>>>      2 (eval):3: failed to load module `zsh/db/gdbm':
>>>>      3 /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared object file: No such file or directory
>>>>      4 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load zsh/db/gdbm module for testing)

Personally I think it'd be good to hide that particular
error message; line 4 tells the user what he needs to know.

CHeers,

Daniel