From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] __git_recent_commits: prefer recent commit objects
Date: Sun, 9 Apr 2017 18:25:24 +0000 [thread overview]
Message-ID: <20170409182524.GA7780@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20170409152335.20372-1-genml+zsh-workers@thequod.de>
Daniel Hahler wrote on Sun, Apr 09, 2017 at 17:23:35 +0200:
> RFC: Daniel Shahaf mentioned that `expl=()` might not be right here after all,
> so I am waiting for feedback before pushing it.
I don't think fixing that needs to block this patch. I suggest that,
whether the expl=() is right or not, to go ahead with this patch, since
it doesn't make things any worse in that front and does fix your issue;
and if the expl=() is wrong, we can fix it in a separate patch.
next prev parent reply other threads:[~2017-04-09 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 15:23 Daniel Hahler
2017-04-09 18:25 ` Daniel Shahaf [this message]
2017-04-09 18:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409182524.GA7780@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).