zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: PATCH: perform expansion for precommand modifiers
Date: Mon, 1 May 2017 18:31:07 +0000	[thread overview]
Message-ID: <20170501183107.GA6421@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20170428100338.27ef869c@pwslap01u.europe.root.pri>

Peter Stephenson wrote on Fri, Apr 28, 2017 at 10:03:38 +0100:
> Bart Schaefer <schaefer@brasslantern.com> wrote:
> > On Apr 27,  9:40am, Peter Stephenson wrote:
> > This isn't testing the right thing.  The complaint was that the -c option
> > of exec was treated as a command name if the keyword was quoted.
> 
> I think we can fix this by adding a test for that.
> 
> > Similarly for "command -p" which now that I try it is still broken:
> > 
> > torch% \command -p echo
> > zsh: command not found: -p
> 
> That's nothing to do with the quoting.  I assumed we had a test for -p
> without -v or -V, but apparently we don't, so I didn't notice there was
> an extra node to remove.

Updated docs, replaced 41013.

diff --git a/NEWS b/NEWS
index 5479251..568b160 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,17 @@ CHANGES FROM PREVIOUS VERSIONS OF ZSH
 
 Note also the list of incompatibilities in the README file.
 
+Changes from 5.3.1 to 5.4
+-------------------------
+
+The 'exec' and 'command' precommand modifiers, and options to them, are
+now parsed after parameter expansion.  Previously, both the modifier and
+any options to it were parsed between alias expansion and parameter
+expansion (see zshexpn(1)), so they could neither be quoted nor be the
+result of parameter expansion.  Examples: 's=command; $s -V ls' and
+'\command -V ls' now work as expected.
+
+
 Changes from 5.2 to 5.3.1
 -------------------------
 



      reply	other threads:[~2017-05-01 18:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170425091533eucas1p26af70366557848059af3b7c8957f1d55@eucas1p2.samsung.com>
2017-04-25  9:15 ` Peter Stephenson
2017-04-26 19:45   ` Daniel Shahaf
2017-04-26 21:25     ` Bart Schaefer
2017-04-27  8:40       ` Peter Stephenson
2017-04-27 23:12         ` Bart Schaefer
2017-04-28  9:03           ` Peter Stephenson
2017-05-01 18:31             ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501183107.GA6421@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).