zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: PATCH: perform expansion for precommand modifiers
Date: Wed, 26 Apr 2017 19:45:17 +0000	[thread overview]
Message-ID: <20170426194517.GA12961@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20170425101520.23910ede@pwslap01u.europe.root.pri>

Peter Stephenson wrote on Tue, Apr 25, 2017 at 10:15:20 +0100:
> This is something I've been meaning to get around to for a while.
> "exec" and "command" have a for quite a long time now taken options,
> but the parsing hadn't caught up properly so that it wasn't possible to
> put the options, let alone the modifiers themselves, in a parameter.
> This fixes both --- see the new tests.

Is this worth a NEWS entry?  (not README since the change is backwards
compatible)

diff --git a/NEWS b/NEWS
index 5479251..4b5e12a 100644
--- a/NEWS
+++ b/NEWS
@@ -4,5 +4,15 @@ CHANGES FROM PREVIOUS VERSIONS OF ZSH
 
 Note also the list of incompatibilities in the README file.
 
+Changes from 5.3.1 to 5.4
+-------------------------
+
+The 'exec' and 'command' precommand modifiers, and options to them, are
+now parsed after parameter expansion.  Previously, both the modifier
+and any options to it were only recognised if they had already been
+present in the command line before any parameter references were expanded.
+Example: 's=command; $s -V ls' now works as expected.
+
+
 Changes from 5.2 to 5.3.1
 -------------------------


  reply	other threads:[~2017-04-26 19:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170425091533eucas1p26af70366557848059af3b7c8957f1d55@eucas1p2.samsung.com>
2017-04-25  9:15 ` Peter Stephenson
2017-04-26 19:45   ` Daniel Shahaf [this message]
2017-04-26 21:25     ` Bart Schaefer
2017-04-27  8:40       ` Peter Stephenson
2017-04-27 23:12         ` Bart Schaefer
2017-04-28  9:03           ` Peter Stephenson
2017-05-01 18:31             ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426194517.GA12961@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).