From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] repair conds where - within cond name
Date: Fri, 11 Aug 2017 13:18:27 -0400 [thread overview]
Message-ID: <20170811171827.GA62807@tower.spodhuis.org> (raw)
In-Reply-To: <20170811093133.2ff7c1b0@pwslap01u.europe.root.pri>
On 2017-08-11 at 09:31 +0100, Peter Stephenson wrote:
> On Thu, 10 Aug 2017 22:02:46 -0400
> Phil Pennock <zsh-workers+phil.pennock@spodhuis.org> wrote:
> > + lookup = ztrdup(name);
>
> I'd be inclined just to put this on the heap. I can do that myself if
> that's OK.
I'm guessing you meant stack, or some short-lived pool. I couldn't
remember the means to do that in zsh and brief looking didn't help, so I
went with what worked.
"Yes" is the answer. Go ahead.
I could switch a bunch of memory stuff in the PCRE/regex libs over to
the same too, at the same time as adding tests, if I manage to get some
spare time. This one is nagging at me right now, so it might happen.
-Phil
next prev parent reply other threads:[~2017-08-11 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86221c7e-aa71-28a7-21c2-8ed800090edd@bureaucracy.de>
[not found] ` <20170811010701.GA94571@tower.spodhuis.org>
2017-08-11 1:36 ` -pcre-match doesn't work since version 5.4.1 Phil Pennock
2017-08-11 1:49 ` Bart Schaefer
2017-08-11 2:02 ` [PATCH] repair conds where - within cond name Phil Pennock
2017-08-11 8:31 ` Peter Stephenson
2017-08-11 17:18 ` Phil Pennock [this message]
2017-08-11 18:45 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811171827.GA62807@tower.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).