zsh-workers
 help / color / mirror / code / Atom feed
From: Stephane Chazelas <stephane.chazelas@gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: $userdirs empty in non-interactive shells
Date: Thu, 7 Dec 2017 11:29:50 +0000	[thread overview]
Message-ID: <20171207112950.GA8258@chaz.gmail.com> (raw)

Hi,

$userdirs seems to only work in interactive shells. That seems
to be due to:

> mod_export void
> adduserdir(char *s, char *t, int flags, int always)
> {
>     Nameddir nd;
>     char *eptr;
>
>     /* We don't maintain a hash table in non-interactive shells. */
>     if (!interact)
>         return;

Why? It seems to me it would make as much sense to hash it in
non-interactive shells. It may be useful to be able to flush
that cache though.

Note that upon expanding $userdirs in non-interactive shells,
the code still loops over the pw entries.

So, if we don't want to change the behaviour, we may still want
to disable $userdirs altogether in non-interactive shells (and
update the documentation).

-- 
Stephane


             reply	other threads:[~2017-12-07 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 11:29 Stephane Chazelas [this message]
2017-12-07 13:43 ` Stephane Chazelas
2017-12-08 12:23 ` Stephane Chazelas
2017-12-08 12:31   ` Peter Stephenson
2017-12-08 19:46     ` Stephane Chazelas
2018-06-17 14:14 ` Stephane Chazelas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207112950.GA8258@chaz.gmail.com \
    --to=stephane.chazelas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).