From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: dana <dana@dana.is>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add ability to ignore running jobs when check_jobs is set
Date: Fri, 22 Dec 2017 20:05:36 +0000 [thread overview]
Message-ID: <20171222200536.14e92995@ntlworld.com> (raw)
In-Reply-To: <491C71DF-5618-41F7-9823-A3AE769A3C62@dana.is>
On Thu, 21 Dec 2017 22:33:13 -0600
dana <dana@dana.is> wrote:
> The tests seem to work well and are much more comprehensive than what
> was there before (i.e., almost nothing), but they feel a bit strange
> somehow. Let me know if you have any thoughts as to how to make them
> less brittle or more idiomatic.
The tests actually fail with debug on because you get output
utils.c:1836: BUG: Impossible TIOCGWINSZ rows
utils.c:1860: BUG: Impossible TIOCGWINSZ cols
I don't think that output's actually very useful anyway, even in debug
mode --- I've been getting this occasionally for years. I think I'll
commit this with a change so there's no whine if the number of rows or
columns is zero.
pws
prev parent reply other threads:[~2017-12-22 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 4:33 dana
2017-12-22 20:05 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222200536.14e92995@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=dana@dana.is \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).