zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: crash/hang with gcc 5+ -O2 and --enable-zsh-mem
Date: Mon, 26 Feb 2018 15:13:24 -1000	[thread overview]
Message-ID: <20180227011324.pp4fiot5jtt5rpcc@gmail.com> (raw)
In-Reply-To: <20180226202446.08f467c8@ntlworld.com>

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

On Mon, Feb 26, 2018 at 08:24:46PM +0000, Peter Stephenson wrote:
> Can't see a problem with this apart from a minor performance hit.
> calloc isn't used anywhere this would be a big deal, I don't think.  I
> committed it, thanks.
> 
> I suppose gcc really wants looking at too...

Cheers.

I honestly still am completely confused at how strlen() could in any
way be related to this (and yet, it most certainly is as far as gcc
is concered) and _why_ calloc() is even a viable candidate for malloc()
sibling-call optimization in the first place.

I am also sort of thinking this is a gcc bug, but I have no idea
where to even start looking in that abyss known to some as the
gcc codebase. I'll keep my ear to the ground regardless; I find it
*very* hard to believe that zsh is the only codebase affected
by this optimization peculiarity.

-- 
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2018-02-27  1:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 19:01 Mikael Magnusson
2018-02-25  0:13 ` Joey Pabalinas
2018-02-25  7:06   ` Joey Pabalinas
2018-02-25  7:07     ` Joey Pabalinas
2018-02-26 20:24     ` Peter Stephenson
2018-02-27  1:13       ` Joey Pabalinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180227011324.pp4fiot5jtt5rpcc@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).