From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: $(<nofile) doesn't set $? to non-zero
Date: Thu, 15 Mar 2018 09:23:05 +0000 [thread overview]
Message-ID: <20180315092305.6fe4ad17@camnpupstephen> (raw)
In-Reply-To: <20180315071204.GA10057@chaz.gmail.com>
On Thu, 15 Mar 2018 07:12:04 +0000
Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> 2018-03-14 14:50:04 +0000, Peter Stephenson:
> > On Wed, 14 Mar 2018 14:42:48 +0000
> > Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> > > Would it be worth doing some:
> > >
> > > ret = readoutput(stream, qt);
> > > if (errno) {
> > > zwarn("%e: %s", errno, s);
> > > lastval = cmdoutval = 1;
> > > }
> > > return ret;
> > >
> > > there (or something cleaner to avoid relying on errno)?
> >
> > The return value is the linked list as we're in the context of
> > substitution, not command execution, which isn't easy to change
> > without a complete rewrite.
> [...]
>
> Why not just pass the error as a return argument like in the
> patch below?
That should be more consistent, thanks. I've committed it (minor
tweaks).
pws
next prev parent reply other threads:[~2018-03-15 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180314103335epcas4p30222f0df02adda27cbddbe62075ff9ad@epcas4p3.samsung.com>
2018-03-14 10:32 ` Stephane Chazelas
2018-03-14 10:54 ` Peter Stephenson
2018-03-14 14:42 ` Stephane Chazelas
2018-03-14 14:50 ` Peter Stephenson
2018-03-15 7:12 ` Stephane Chazelas
2018-03-15 7:25 ` EILSEQ in the C locale? (Was: $(<nofile) doesn't set $? to non-zero) Stephane Chazelas
2018-03-19 0:09 ` Bart Schaefer
2018-03-15 9:23 ` Peter Stephenson [this message]
2018-03-15 11:10 ` $(<nofile) doesn't set $? to non-zero Stephane Chazelas
2018-03-16 8:24 ` Stephane Chazelas
2018-03-14 11:04 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315092305.6fe4ad17@camnpupstephen \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).