From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: Why sourcing a file is not faster than doing a loop with eval, zle -N
Date: Sun, 18 Mar 2018 23:07:38 -1000 [thread overview]
Message-ID: <20180319090738.hyri7bnr5siowjuk@gmail.com> (raw)
In-Reply-To: <7096.1521281564@thecus>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
> On Sat, Mar 17, 2018 at 11:12:44AM +0100, Oliver Kiddle wrote:
> I didn't really follow the original discussion. But if getline() solves
> an issue and the #ifdef mess to handle old systems isn't too bad (at
> least compared to the rest of the shell) then I'd say cook up a patch.
> For compatibility, getline() is the sort of thing where we can just
> include a replacement implementation so the mess can be separate from
> the actual code. I've included a suitable implementation below.
After spending a bit of time writing up a patch and testing it, getline()
unfortunately didn't seem to solve the original performance problem in
any sort of ground-breaking way, and so after thinking it over a bit
more, I don't really think this would end up being would be any sort
of worthwhile solution.
For such a tiny performance benefit, it seem like we would be better
served looking for a solution somewhere else.
The getline() replacement implementation was very appreciated, anyway; even
though this ended up going nowhere, it saved me a day or two in getting
here :)
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-19 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 22:19 Joey Pabalinas
[not found] ` <7096.1521281564@thecus>
2018-03-19 9:07 ` Joey Pabalinas [this message]
2018-03-19 14:24 ` Sebastian Gniazdowski
2018-03-20 5:14 ` Joey Pabalinas
[not found] <etPan.594513a8.516100cd.10b2e__10513.1716504276$1497699329$gmane$org@zdharma.org>
[not found] ` <20170619122413.GA9294@chaz.gmail.com>
[not found] ` <170619083116.ZM17323__41722.0601499595$1497886320$gmane$org@torch.brasslantern.com>
[not found] ` <20170619161601.GB9294@chaz.gmail.com>
2017-06-19 19:28 ` Peter Stephenson
2017-06-19 19:57 ` Bart Schaefer
2017-06-19 20:38 ` Bart Schaefer
2017-06-19 20:44 ` Peter Stephenson
2017-06-19 20:52 ` Peter Stephenson
2017-06-19 23:01 ` Bart Schaefer
2017-12-15 11:01 ` Sebastian Gniazdowski
2017-12-23 15:01 ` Sebastian Gniazdowski
2017-12-23 15:47 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319090738.hyri7bnr5siowjuk@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).