From: Sebastian Gniazdowski <psprint@zdharma.org>
To: Oliver Kiddle <okiddle@yahoo.co.uk>,
Joey Pabalinas <joeypabalinas@gmail.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>,
"Joey Pabalinas" <joeypabalinas@gmail.com>
Subject: Re: Why sourcing a file is not faster than doing a loop with eval, zle -N
Date: Mon, 19 Mar 2018 15:24:08 +0100 [thread overview]
Message-ID: <etPan.5aafc808.7ce5f63c.159ee@zdharma.org> (raw)
In-Reply-To: <20180319090738.hyri7bnr5siowjuk@gmail.com>
On 19 marca 2018 at 10:07:38, Joey Pabalinas (joeypabalinas@gmail.com) wrote:
> After spending a bit of time writing up a patch and testing it, getline()
> unfortunately didn't seem to solve the original performance problem
By "original problem" you mean: sig-mask being updated too often (through a syscall, like strace reported) ? AFAIR Bart patch (committed) vs. Peter patch (fgets, not commited) was resolved to: fgets is faster, but it has problems, and Bart's patch is too very fast, and correctly solves many-syscalls problem. So if you wrote the same what Peter did, but instead of fgets you used getline, then it should solve too the many-syscalls problem and be even faster than HEAD. So maybe by "original issue" you mean something else, probably: "getline should be significantly faster than current HEAD (Bart's patch commited)" ? So in general all this would mean that getline doesn't provide performance gains comparing to current HEAD?
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next prev parent reply other threads:[~2018-03-19 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 22:19 Joey Pabalinas
[not found] ` <7096.1521281564@thecus>
2018-03-19 9:07 ` Joey Pabalinas
2018-03-19 14:24 ` Sebastian Gniazdowski [this message]
2018-03-20 5:14 ` Joey Pabalinas
[not found] <etPan.594513a8.516100cd.10b2e__10513.1716504276$1497699329$gmane$org@zdharma.org>
[not found] ` <20170619122413.GA9294@chaz.gmail.com>
[not found] ` <170619083116.ZM17323__41722.0601499595$1497886320$gmane$org@torch.brasslantern.com>
[not found] ` <20170619161601.GB9294@chaz.gmail.com>
2017-06-19 19:28 ` Peter Stephenson
2017-06-19 19:57 ` Bart Schaefer
2017-06-19 20:38 ` Bart Schaefer
2017-06-19 20:44 ` Peter Stephenson
2017-06-19 20:52 ` Peter Stephenson
2017-06-19 23:01 ` Bart Schaefer
2017-12-15 11:01 ` Sebastian Gniazdowski
2017-12-23 15:01 ` Sebastian Gniazdowski
2017-12-23 15:47 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.5aafc808.7ce5f63c.159ee@zdharma.org \
--to=psprint@zdharma.org \
--cc=joeypabalinas@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).