zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Cc: Joey Pabalinas <joeypabalinas@gmail.com>
Subject: [PATCH] Allow '=' aliases to be used with -L
Date: Wed, 21 Mar 2018 15:19:05 -1000	[thread overview]
Message-ID: <20180322011905.45n377wsxp62k57e@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Special case '=' aliases so that they can be output correctly
by -L and be used in startup scripts.

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>

 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/Src/hashtable.c b/Src/hashtable.c
index b7baa314220509240d..62f8e9df3b99b6d5e2 100644
--- a/Src/hashtable.c
+++ b/Src/hashtable.c
@@ -1303,11 +1303,17 @@ printaliasnode(HashNode hn, int printflags)
     }
 
     if (printflags & PRINT_LIST) {
-	/* Fast fail on unrepresentable values. */
+	/*
+	 * '=' aliases need to be special
+	 * cased with direct alias table
+	 * assignment (`aliases[=]=...`).
+	 */
 	if (strchr(a->node.nam, '=')) {
-	    zwarn("invalid alias '%s' encountered while printing aliases", 
-		  a->node.nam);
-	    /* ### TODO: Return an error status to the C caller */
+	    printf("aliases[=]");
+	    putchar('=');
+	    quotedzputs(a->text, stdout);
+
+	    putchar('\n');
 	    return;
 	}
 
-- 
2.16.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2018-03-22  1:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22  1:19 Joey Pabalinas [this message]
2018-03-22  1:37 ` Bart Schaefer
2018-03-22  2:58   ` Joey Pabalinas
2018-03-22  3:08     ` Bart Schaefer
2018-03-22  3:12       ` Joey Pabalinas
2018-03-23  6:32     ` Daniel Shahaf
2018-03-23  7:39       ` Joey Pabalinas
2018-03-23 10:09 ` Nikolay Aleksandrovich Pavlov (ZyX)
2018-03-23 10:36   ` Joey Pabalinas
2018-03-23 17:29 ` Stephane Chazelas
2018-03-24  0:02   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322011905.45n377wsxp62k57e@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).