zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Allow '=' aliases to be used with -L
Date: Fri, 23 Mar 2018 06:32:58 +0000	[thread overview]
Message-ID: <20180323063258.55uicn5bavsss4yw@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20180322025807.u3y7dph2vi6ls2ll@gmail.com>

Joey Pabalinas wrote on Wed, Mar 21, 2018 at 16:58:07 -1000:
> +++ b/Src/hashtable.c
> @@ -1303,11 +1303,23 @@ printaliasnode(HashNode hn, int printflags)
>  	if (strchr(a->node.nam, '=')) {
> +	    printf("aliases[=]=");

For future reference, a->node.nam could also have been "foo=bar", which
is not a useful value (assignments have precedence over aliases) but would
be misserialized by the patch as written.

Cheers,

Daniel


  parent reply	other threads:[~2018-03-23  6:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22  1:19 Joey Pabalinas
2018-03-22  1:37 ` Bart Schaefer
2018-03-22  2:58   ` Joey Pabalinas
2018-03-22  3:08     ` Bart Schaefer
2018-03-22  3:12       ` Joey Pabalinas
2018-03-23  6:32     ` Daniel Shahaf [this message]
2018-03-23  7:39       ` Joey Pabalinas
2018-03-23 10:09 ` Nikolay Aleksandrovich Pavlov (ZyX)
2018-03-23 10:36   ` Joey Pabalinas
2018-03-23 17:29 ` Stephane Chazelas
2018-03-24  0:02   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323063258.55uicn5bavsss4yw@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=joeypabalinas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).