From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Joey Pabalinas <joeypabalinas@gmail.com>,
Stephane Chazelas <stephane.chazelas@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: "echo | ps -j $(:) | cat | cat | cat" runs components in different process groups
Date: Fri, 23 Mar 2018 22:05:14 -1000 [thread overview]
Message-ID: <20180324080514.txxyrb3qiztu4pqt@gmail.com> (raw)
In-Reply-To: <180323221959.ZM27569@torch.brasslantern.com>
[-- Attachment #1: Type: text/plain, Size: 2514 bytes --]
On Fri, Mar 23, 2018 at 10:19:59PM -0700, Bart Schaefer wrote:
> It may be this easy?
>
> It fixes the specific example in the subject by causing the zsh parent
> shell to re-assume job leader for all subsequent processes in the pipeline
> if the current leader is dead. However, I'm concerned that if the first
> leader is reaped after a few processes in a long pipeline are created,
> there may still be a new process group asserted for remaining processes.
>
> On the other hand I haven't found an example where that occurs, instead
> I get jobs where the process group ID is the PID of the now-dead leader.
> It could be I just haven't constructed the right test.
It's kind of an *incredibly* unlikely edge-case but FWIW:
> $ echo | ps -j $(: $(cat)) | cat | cat | cat
The shell _seems_ to completely lock up after applying your patch; on
my zsh 5.4.2 release version there are no problems (aside from the
original process group leader issues).
This is the shell output after I `pkill -9 cat`:
> $ echo | ps -j $(: $(cat)) | cat | cat | cat
> ^C^C^C^C^Z^Z^Z^Z
> PID PGID SID TTY TIME CMD
> 16007 16007 18994 pts/5 00:00:03 zsh
> 17582 17582 18994 pts/5 00:00:01 zsh
> 18994 18994 18994 pts/5 00:00:26 zsh
> 20626 17582 18994 pts/5 00:00:00 ps
> 20627 17582 18994 pts/5 00:00:00 cat
> 20629 17582 18994 pts/5 00:00:00 cat
The shell _appears_ to deadlock and accordingly ignores all user
input such as ^C or ^D (but you can, however, still externally
kill the parent zsh process group leader with any fatal signal
or `kill -9 cat` without issue). It seems it's mostly an issue
stemming from the parent zsh process still being the process
group leader; this causes cat to wait indefinitely for input
while being unable to actually receive any.
In my zsh release version 5.4.2 ^C works as expected, and to
be honest I don't actually know if this is anything worth
being concerned about.
Output from the release version (no need to ^C or ^D or anything):
> $ echo | ps -j $(: $(cat)) | cat | cat | cat
> cat: -: Input/output error
> PID PGID SID TTY TIME CMD
> 21366 21366 27814 pts/12 00:00:00 ps
> 21367 21367 27814 pts/12 00:00:00 cat
> 21368 21368 27814 pts/12 00:00:00 cat
> 27814 27814 27814 pts/12 00:00:03 zsh
The "cat: -: Input/output error" and differing number of entries is kind
interesting, although I would be lying if I said that I understood why.
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-24 8:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 16:16 Stephane Chazelas
2018-03-23 23:36 ` Bart Schaefer
2018-03-24 5:19 ` Bart Schaefer
2018-03-24 8:05 ` Joey Pabalinas [this message]
2018-03-24 17:34 ` Stephane Chazelas
2018-03-24 22:23 ` Bart Schaefer
2018-03-25 7:00 ` Stephane Chazelas
2018-03-25 8:26 ` Stephane Chazelas
2018-03-25 7:48 ` Stephane Chazelas
2018-03-25 18:09 ` Stephane Chazelas
2018-03-27 10:17 ` Stephane Chazelas
2018-03-24 22:09 ` Bart Schaefer
2018-04-10 11:45 ` Peter Stephenson
2018-04-10 13:59 ` Peter Stephenson
2018-04-11 22:10 ` Bart Schaefer
2018-04-12 16:23 ` Peter Stephenson
2018-04-15 16:23 ` Stephane Chazelas
2018-04-15 17:38 ` Bart Schaefer
2018-04-15 18:58 ` Stephane Chazelas
2018-04-17 5:39 ` Bart Schaefer
2018-04-17 9:19 ` Peter Stephenson
2018-04-17 16:09 ` Bart Schaefer
2018-04-17 16:27 ` Bart Schaefer
2018-04-17 16:35 ` Peter Stephenson
2018-04-17 17:52 ` Bart Schaefer
2018-04-19 9:40 ` Peter Stephenson
2018-04-20 9:28 ` Forking earlier for background code Peter Stephenson
2018-04-20 10:01 ` Peter Stephenson
2018-04-20 12:54 ` Vin Shelton
[not found] ` <CGME20180420132008eucas1p1c297624e870975cd892c74254970faab@eucas1p1.samsung.com>
2018-04-20 13:20 ` Peter Stephenson
2018-04-20 16:01 ` Vin Shelton
2018-04-23 8:29 ` Peter Stephenson
2018-05-01 9:23 ` Peter Stephenson
[not found] ` <F3A62E38-24E2-4A62-8E19-F54C9B81E9E5@kba.biglobe.ne.jp>
2018-04-23 13:52 ` "echo | ps -j $(:) | cat | cat | cat" runs components in different process groups Peter Stephenson
2018-04-23 14:03 ` Peter Stephenson
[not found] ` <CGME20180423140859eucas1p2591bf1422614209979d4890383268c37@eucas1p2.samsung.com>
2018-04-23 14:08 ` Peter Stephenson
2018-04-23 15:29 ` Jun T.
2018-04-18 6:29 ` Stephane Chazelas
2018-04-18 16:33 ` Bart Schaefer
2018-04-10 9:53 ` Peter Stephenson
2018-03-25 7:38 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324080514.txxyrb3qiztu4pqt@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=stephane.chazelas@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).