[PATCH] _powerd: add -M and -m options

[PATCH] _powerd: add -M and -m options

[Eitan Adler]

These are specific numeric values. While we can be more careful about
allowed values, limiting to numbers is good enough for now.

Signed-off-by: Eitan Adler <lists@eitanadler.com>
---
 Completion/BSD/Command/_powerd | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Completion/BSD/Command/_powerd b/Completion/BSD/Command/_powerd
index 18a9fb437..88d7c401b 100644
--- a/Completion/BSD/Command/_powerd
+++ b/Completion/BSD/Command/_powerd
@@ -6,6 +6,8 @@ _arguments -s \
     "-a[mode to use while on AC power]:mode:($powerd_mode)" \
     "-b[mode to use while on battery power]:mode:($powerd_mode)" \
     '-i[CPU idle percent level when begin to degrade performance]:percent:' \
+    "-m[maximum frequency to throttle down to]:freq: :_guard '[0-9]#' 'numeric value'" \
+    "-M[maximum frequency to throttle up to]:freq: :_guard '[0-9]#' 'numeric value'" \
     "-n[mode to use normally when the AC line state is unknown]:mode:($powerd_mode)" \
     '-p[polling interval (in milliseconds) for AC line state and system idle levels]:interval:' \
     '-P[alternative pidfile]:pidfile:_files' \
-- 
2.17.0

Re: [PATCH] _powerd: add -M and -m options

[Oliver Kiddle]

Eitan Adler wrote:
> allowed values, limiting to numbers is good enough for now.
>
> Signed-off-by: Eitan Adler <lists@eitanadler.com>
> ---
>  Completion/BSD/Command/_powerd | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Completion/BSD/Command/_powerd b/Completion/BSD/Command/_powerd
> index 18a9fb437..88d7c401b 100644
> --- a/Completion/BSD/Command/_powerd
> +++ b/Completion/BSD/Command/_powerd
> @@ -6,6 +6,8 @@ _arguments -s \
>      "-a[mode to use while on AC power]:mode:($powerd_mode)" \
>      "-b[mode to use while on battery power]:mode:($powerd_mode)" \
>      '-i[CPU idle percent level when begin to degrade performance]:percent:' \
> +    "-m[maximum frequency to throttle down to]:freq: :_guard '[0-9]#' 'numeric value'" \
> +    "-M[maximum frequency to throttle up to]:freq: :_guard '[0-9]#' 'numeric value'" \

The syntax here isn't right as the : : in the middle should not be
there. The second argument after -m or -M will give you the whole _guard
bit as a description.

What did you intend as the description? Abbreviating the word
"frequency" to "freq" is fairly pointless and "numeric value" is not
entirely helpful. "frequency" is better. Better still, include the units
in round brackets and the default value in square brackets.

_guard is not necessary here. _guard solves a particular problem
that occurs when something that can't be completed but for which a
message is useful is completed alongside something for which there are
matches. After -m, only arguments to -m are relevant so _guard isn't
needed.

Assuming the units are MHz, this leaves something like:

  '-m[maximum frequency to throttle down to]:frequency (MHz)'

Oliver

Re: [PATCH] _powerd: add -M and -m options

[Eitan Adler]

On 27 May 2018 at 12:16, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Eitan Adler wrote:
>> allowed values, limiting to numbers is good enough for now.
>>
>> Signed-off-by: Eitan Adler <lists@eitanadler.com>
>> ---
>>  Completion/BSD/Command/_powerd | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Completion/BSD/Command/_powerd b/Completion/BSD/Command/_powerd
>> index 18a9fb437..88d7c401b 100644
>> --- a/Completion/BSD/Command/_powerd
>> +++ b/Completion/BSD/Command/_powerd
>> @@ -6,6 +6,8 @@ _arguments -s \
>>      "-a[mode to use while on AC power]:mode:($powerd_mode)" \
>>      "-b[mode to use while on battery power]:mode:($powerd_mode)" \
>>      '-i[CPU idle percent level when begin to degrade performance]:percent:' \
>> +    "-m[maximum frequency to throttle down to]:freq: :_guard '[0-9]#' 'numeric value'" \
>> +    "-M[maximum frequency to throttle up to]:freq: :_guard '[0-9]#' 'numeric value'" \
>
> The syntax here isn't right as the : : in the middle should not be
> there. The second argument after -m or -M will give you the whole _guard
> bit as a description.
>
> What did you intend as the description? Abbreviating the word
> "frequency" to "freq" is fairly pointless and "numeric value" is not
> entirely helpful. "frequency" is better. Better still, include the units
> in round brackets and the default value in square brackets.

I copied this from the man page.

> _guard is not necessary here. _guard solves a particular problem
> that occurs when something that can't be completed but for which a
> message is useful is completed alongside something for which there are
> matches. After -m, only arguments to -m are relevant so _guard isn't
> needed.


Makes sense.  I copied this from another completer. This also explains
why it didn't work exactly the way I expected :)


>
>   '-m[maximum frequency to throttle down to]:frequency (MHz)'

New patch coming up shortly.


-- 
Eitan Adler

[PATCH] _powerd: add -M and -m options

[Eitan Adler]

These are specific numeric values. While we can be more careful about
allowed values, limiting to numbers is good enough for now.

Signed-off-by: Eitan Adler <lists@eitanadler.com>
---
 Completion/BSD/Command/_powerd | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Completion/BSD/Command/_powerd b/Completion/BSD/Command/_powerd
index 18a9fb437..05c03ab15 100644
--- a/Completion/BSD/Command/_powerd
+++ b/Completion/BSD/Command/_powerd
@@ -6,6 +6,8 @@ _arguments -s \
     "-a[mode to use while on AC power]:mode:($powerd_mode)" \
     "-b[mode to use while on battery power]:mode:($powerd_mode)" \
     '-i[CPU idle percent level when begin to degrade performance]:percent:' \
+    '-m[minimum frequency to throttle down to]:frequency (MHz)' \
+    '-M[maximum frequency to throttle up to]:frequency (MHz)' \
     "-n[mode to use normally when the AC line state is unknown]:mode:($powerd_mode)" \
     '-p[polling interval (in milliseconds) for AC line state and system idle levels]:interval:' \
     '-P[alternative pidfile]:pidfile:_files' \
-- 
2.17.1