From: Eitan Adler <lists@eitanadler.com>
To: zsh-workers@zsh.org
Cc: Eitan Adler <lists@eitanadler.com>
Subject: [PATCH 2/2] Fix two C nits
Date: Sat, 16 Jun 2018 01:04:27 +0000 [thread overview]
Message-ID: <20180616010427.2916-2-lists@eitanadler.com> (raw)
- avoid returning from a function that will never return
- use "ifdef" instead of "if" for checking if preprocessor exists
Signed-off-by: Eitan Adler <lists@eitanadler.com>
---
Src/exec.c | 1 -
Src/zsh_system.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/Src/exec.c b/Src/exec.c
index d44527841..b36bcef64 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -4954,7 +4954,6 @@ getpipe(char *cmd, int nullexec)
execode(prog, 0, 1, out ? "outsubst" : "insubst");
cmdpop();
_exit(lastval);
- return 0;
}
/* open pipes with fds >= 10 */
diff --git a/Src/zsh_system.h b/Src/zsh_system.h
index 5339b496f..d9b8617c5 100644
--- a/Src/zsh_system.h
+++ b/Src/zsh_system.h
@@ -735,7 +735,7 @@ extern char **environ;
/* These variables are sometimes defined in, *
* and needed by, the termcap library. */
-#if MUST_DEFINE_OSPEED
+#ifdef MUST_DEFINE_OSPEED
extern char PC, *BC, *UP;
extern short ospeed;
#endif
--
2.17.1
next reply other threads:[~2018-06-16 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180616021439epcas4p327f4346b40d9e10d94ce055058fe0d71@epcas4p3.samsung.com>
2018-06-16 1:04 ` Eitan Adler [this message]
2018-06-18 9:22 ` Peter Stephenson
2018-06-19 5:31 ` Eitan Adler
2018-06-19 13:46 ` Vincent Lefevre
2018-06-19 14:13 ` Peter Stephenson
2018-06-19 14:38 ` Vincent Lefevre
2018-06-19 15:59 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180616010427.2916-2-lists@eitanadler.com \
--to=lists@eitanadler.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).