zsh-workers
 help / color / mirror / code / Atom feed
From: Anton Shestakov <av6@dwimlabs.net>
To: zsh-workers@zsh.org
Cc: Anton Shestakov <av6@dwimlabs.net>
Subject: [PATCH 0/5] An update for Completion/Unix/Command/_hg
Date: Mon,  6 Aug 2018 15:28:08 +0800	[thread overview]
Message-ID: <20180806072813.5051-1-av6@dwimlabs.net> (raw)

Hey there zsh folks,

One day I decided to update completion file for hg (Mercurial), even though I
didn't really know how zsh completion system works. A week later, I still don't
know how it works, but I believe I have something that's worth sending. So here
goes.

This update is based on hg 4.0, which is what Debian stable has at the moment.
When comparing it to 4.7, which has been released recently, it lacks some newer
command line flags (e.g. --dry-run and --interactive for more commands), but
let's assume people don't upgrade often and 4.0 is the least they have. I can
update the completion file based on 4.7 later, if people think it's a good
idea.

In general, I can fix errors and things that I missed, but preferably in a
follow-up, because I was staring at these diffs for a whole week. Diffs as in
plural because I have an update to upstream... downstream? sidestream's
completion file: Mercurial's own contrib/zsh_completion, which I'm intending to
base on 4.7. My idea is to run things through people who know zsh completion
better first, and then send patches to Mercurial.

I've split the work into 5 patches for easier reviewing, because they do need
reviewing -- I'd rather not have any errors in a file that gets updated once a
year. Thanks in advance!

Anton Shestakov (5):
  _hg: rename _hg_style_opts to _hg_template_opts
  _hg: declare appropriate local parameters for ->string form
  _hg: add forget, phase, summary
  _hg: update all options
  _hg: drop -w, add -S to _arguments

 Completion/Unix/Command/_hg | 357 ++++++++++++++++++++++++++------------------
 1 file changed, 213 insertions(+), 144 deletions(-)

-- 
2.11.0


             reply	other threads:[~2018-08-06  7:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  7:28 Anton Shestakov [this message]
2018-08-06  7:28 ` [PATCH 1/5] _hg: rename _hg_style_opts to _hg_template_opts Anton Shestakov
2018-08-06  7:28 ` [PATCH 2/5] _hg: declare appropriate local parameters for ->string form Anton Shestakov
2018-08-06  9:20   ` Daniel Shahaf
2018-08-06  9:29     ` Peter Stephenson
2018-08-06 11:09       ` Anton Shestakov
2018-08-06 11:14         ` Peter Stephenson
2018-08-06 12:04         ` Daniel Shahaf
2018-08-06 15:31           ` Anton Shestakov
2018-08-06 15:38             ` Peter Stephenson
2018-08-07  6:15               ` Anton Shestakov
2018-08-06 12:06       ` Daniel Shahaf
2018-08-06 14:00         ` Bart Schaefer
2018-08-06  7:28 ` [PATCH 3/5] _hg: add forget, phase, summary Anton Shestakov
2018-08-06  7:28 ` [PATCH 4/5] _hg: update all options Anton Shestakov
2018-08-06  7:28 ` [PATCH 5/5] _hg: drop -w, add -S to _arguments Anton Shestakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180806072813.5051-1-av6@dwimlabs.net \
    --to=av6@dwimlabs.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).