zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>, zsh-workers@zsh.org
Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string form
Date: Mon, 06 Aug 2018 12:06:08 +0000	[thread overview]
Message-ID: <1533557168.2552060.1464840800.74A5BE28@webmail.messagingengine.com> (raw)
In-Reply-To: <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>

Peter Stephenson wrote on Mon, 06 Aug 2018 10:29 +0100:
> On Mon, 6 Aug 2018 09:20:32 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > To -workers, couldn't we write a wrapper such as the following:
> > 
> >     _added_matches_p() {
> >         local nmatches=$compstate[nmatches]
> >         "$@"
> >         (( nmatches < $compstate[nmatches] ))
> >     }
> > 
> > to reduce the need to manage $ret in every single layer of the
> > callstack?
> 
> Are you suggesting avoiding looking at the return value, but looking at
> what its effect would have been at the point where you would have looked
> it?

Yes.


  parent reply	other threads:[~2018-08-06 12:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  7:28 [PATCH 0/5] An update for Completion/Unix/Command/_hg Anton Shestakov
2018-08-06  7:28 ` [PATCH 1/5] _hg: rename _hg_style_opts to _hg_template_opts Anton Shestakov
2018-08-06  7:28 ` [PATCH 2/5] _hg: declare appropriate local parameters for ->string form Anton Shestakov
2018-08-06  9:20   ` Daniel Shahaf
2018-08-06  9:29     ` Peter Stephenson
2018-08-06 11:09       ` Anton Shestakov
2018-08-06 11:14         ` Peter Stephenson
2018-08-06 12:04         ` Daniel Shahaf
2018-08-06 15:31           ` Anton Shestakov
2018-08-06 15:38             ` Peter Stephenson
2018-08-07  6:15               ` Anton Shestakov
2018-08-06 12:06       ` Daniel Shahaf [this message]
2018-08-06 14:00         ` Bart Schaefer
2018-08-06  7:28 ` [PATCH 3/5] _hg: add forget, phase, summary Anton Shestakov
2018-08-06  7:28 ` [PATCH 4/5] _hg: update all options Anton Shestakov
2018-08-06  7:28 ` [PATCH 5/5] _hg: drop -w, add -S to _arguments Anton Shestakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533557168.2552060.1464840800.74A5BE28@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).