From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Joey Pabalinas <joeypabalinas@gmail.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] select-bracketed: set nocprecedences to force native precedence ordering
Date: Tue, 6 Nov 2018 13:47:16 -1000 [thread overview]
Message-ID: <20181106234716.kwz3yxenaf2ul4b5@gmail.com> (raw)
In-Reply-To: <CAH+w=7YNUjeZMVne6WfF9=MRGMcsroGemCNdTy5Awm0TLpjSRw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Tue, Nov 06, 2018 at 03:40:59PM -0800, Bart Schaefer wrote:
> Not that I object to unsetting cprecedences, but is it necessary to do
> so if you've rearranged the parens?
It isn't, but in my opinion expressions like this always have a tendency
to confuse. I find it helpful to add the parentheses even when not needed
if for no other reason than to make mentally parsing the code easier.
If you think it's a bit superfluous then I don't mind removing that part and
sending a quick v2.
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-06 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 23:34 Joey Pabalinas
2018-11-06 23:40 ` Bart Schaefer
2018-11-06 23:47 ` Joey Pabalinas [this message]
2018-11-07 6:28 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106234716.kwz3yxenaf2ul4b5@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).