zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] Completion: _opkg: Support gain-privileges
Date: Sat, 12 Jan 2019 17:10:28 +0000	[thread overview]
Message-ID: <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <E1AAD4A3-482A-4173-8579-05F0B38951B1@dana.is>

dana wrote on Fri, Jan 11, 2019 at 17:34:17 -0600:
> Also, it's a bit annoying if you have caching enabled and it caches an empty
> array because you forgot to use sudo (or various other reasons depending on
> the function). Maybe _store_cache should learn an option to make it ignore
> empty parameters

I don't think so.  Even an "empty" result could be expensive to compute:
for example, it might require a network round-trip.  I think _opkg
shouldn't call _store_cache when _call_program returns non-zero.

Cheers,

Daniel

  reply	other threads:[~2019-01-12 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 23:34 dana
2019-01-12 17:10 ` Daniel Shahaf [this message]
2019-01-12 19:08   ` dana
2019-01-12 19:24     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).