From: dana <dana@dana.is>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] Completion: _opkg: Support gain-privileges
Date: Sat, 12 Jan 2019 13:08:30 -0600 [thread overview]
Message-ID: <55BD7A82-303D-4C2A-AF6F-350EF34E5E57@dana.is> (raw)
In-Reply-To: <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2>
On 12 Jan 2019, at 11:10, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>I don't think so. Even an "empty" result could be expensive to compute:
>for example, it might require a network round-trip. I think _opkg
>shouldn't call _store_cache when _call_program returns non-zero.
Well, i think that's effectively the same thing in this case and certain
others i'm imagining. (Or at least i assume so; there's not really any
documentation for opkg that i'm aware of, so who knows what actually causes it
to return non-zero.) Just felt like it might save some boiler-plate, which the
caching logic is extremely heavy in already, to have a standard option handle
it. I can just add the guard to each _store_cache call myself, though, obv
dana
next prev parent reply other threads:[~2019-01-12 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 23:34 dana
2019-01-12 17:10 ` Daniel Shahaf
2019-01-12 19:08 ` dana [this message]
2019-01-12 19:24 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BD7A82-303D-4C2A-AF6F-350EF34E5E57@dana.is \
--to=dana@dana.is \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).