From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Zsh crashes on `compadd` when using `_history` completer & zstyle `ignored-patterns` is set
Date: Thu, 28 May 2020 08:44:52 +0000 [thread overview]
Message-ID: <20200528084452.34074159@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAHLkEDv=tfKLvp=4SwHs4nOrkzAWfwZAC+HfFW=z8hrBgC+_ZQ@mail.gmail.com>
Marlon Richert wrote on Thu, 28 May 2020 10:49 +0300:
> On Tue, 26 May 2020 at 21:48, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> >
> > I followed these steps as follows:
> >
> > [[[
> > $ cd "$(mktemp -d)"
> > $ tee .zshrc
> > HISTFILE=${ZDOTDIR:-$HOME}/.zsh_history
> > HISTSIZE=2000
> > SAVEHIST=1000
> > autoload -Uz compinit
> > compinit
> > zstyle ':completion:*' ignored-patterns ''
> > <pressed Ctrl+D>
> > $ yes | head -1001 > .zsh_history
> > $ ZDOTDIR=$PWD $builddir/Src/zsh -d
> > % bindkey -e
> > % <pressed M-/>
> > ]]]
> >
> > The terminal beeped and no crash happened.
> >
> > What's your $ZSH_VERSION and $ZSH_PATCHLEVEL?
> >
>
> $ZSH_VERSION = 5.8
> $ZSH_PATCHLEVEL = zsh-5.8-0-g77d203f
>
> Could the contents of my histfile have an influence on this? If you do `yes
> | head -1001 > .zsh_history`, then there is no realistic data in the
> histfile.
>
That's possible, yes. Can _you_ reproduce the bug using the steps I posted?
I don't have your $HISTFILE, but I can't reproduce the issue if
I substitute my $HISTFILE (using «cp $HISTFILE ./.zsh_history») into the
above steps, and it's longer than 1000 lines.
> I noticed that if I start Zsh without a histfile, then the problem does not
> occur.
What if you start zsh with a empty histfile?
If you can reproduce the problem with your usual histfile but not with
an empty one, try reducing your histfile to the smallest one that does
still reproduce the problem. There are generic instructions at
http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=45791, if you
aren't familiar with the procedure. (They're written for .zshrc but
you can apply them to $HISTFILE as well.)
Can you try reproducing the bug in zsh built from master?
Cheers,
Daniel
next prev parent reply other threads:[~2020-05-28 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 11:02 Marlon Richert
2020-05-26 18:48 ` Daniel Shahaf
2020-05-28 7:49 ` Marlon Richert
2020-05-28 8:44 ` Daniel Shahaf [this message]
2020-06-04 21:31 ` Marlon Richert
2020-06-05 1:42 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528084452.34074159@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).