From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Yasuhiro KIMURA <yasu@utahime.org>
Cc: zsh-workers@zsh.org
Subject: Re: 'make install' fails when build directory is differnet from that of source tree.
Date: Sun, 31 May 2020 01:57:39 +0000 [thread overview]
Message-ID: <20200531015739.4679267a@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200530.180516.365810412746058204.yasu@utahime.org>
Yasuhiro KIMURA wrote on Sat, 30 May 2020 18:05 +0900:
> [Similar problem with help files]
>
> Similar problem happens with 'make install.runhelp' when build is
> out-of-source and source is from tarball.
>
> cd /tmp/zsh/source
> tar xfpvJ /somewhere/zsh-5.8.tar.xz
> cd /tmp/zsh/build
> /tmp/zsh/source/zsh-5.8/configure --srcdir=/tmp/zsh/source/zsh-5.8
> make DESTDIR=/tmp/zsh/install install.runhelp
>
> These steps result in following error.
>
> make[1]: Entering directory '/tmp/zsh/build/Doc'
> if test x"/usr/local/share/zsh/5.8/help" != x""; then \
> /bin/sh /tmp/zsh/source/zsh-5.8/mkinstalldirs /tmp/zsh/install/usr/local/share/zsh/5.8/help; \
> /bin/install -c -m 644 help/* /tmp/zsh/install/usr/local/share/zsh/5.8/help; \
> while read from to; do \
> rm -f /tmp/zsh/install/usr/local/share/zsh/5.8/help/$to || : ; \
> ln -s $from /tmp/zsh/install/usr/local/share/zsh/5.8/help/$to; \
> done < help.txt; \
> fi
> /bin/install: cannot stat 'help/*': No such file or directory
> /bin/sh: 4: cannot open help.txt: No such file
> make[1]: *** [Makefile:482: install.runhelp] Error 2
> make[1]: Leaving directory '/tmp/zsh/build/Doc'
> make: *** [Makefile:226: install.runhelp] Error 2
>
Thanks for the report.
This looks like another effect of the same series of Doc/Makefile.in commits:
76a16498d 43692: Generate man pages in the build dir, rather than the source dir.
b2ddd9717 43404 (after 43392): Fix 'make install' in out-of-tree builds
85ae84e89 43392: dist: Generate doc/help/* and doc/help.txt in builddir rather than srcdir.
For me, the patch I just posted (the second revision, from today) fixes
this issue as well. I also confirmed that `cd $DESTDIR/$prefix/share/zsh/5.8/help && find`
and `cd /usr/share/zsh/help && find` [the latter being my distro's
build] produce identical outputs.
Do let us know if anything else seems amiss.
Cheers,
Daniel
> Best Regards.
>
> ---
> Yasuhiro KIMURA
next prev parent reply other threads:[~2020-05-31 1:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 6:07 Yasuhiro KIMURA
2020-05-29 22:54 ` Daniel Shahaf
2020-05-29 23:42 ` Daniel Shahaf
2020-05-30 9:05 ` Yasuhiro KIMURA
2020-05-31 1:39 ` Daniel Shahaf
2020-05-31 5:36 ` Yasuhiro KIMURA
2020-05-31 1:57 ` Daniel Shahaf [this message]
2020-05-31 7:46 ` Yasuhiro KIMURA
2020-06-01 8:03 ` Daniel Shahaf
2020-06-01 18:23 ` Yasuhiro KIMURA
2020-06-03 1:14 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531015739.4679267a@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=yasu@utahime.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).