zsh-workers
 help / color / mirror / code / Atom feed
From: Yasuhiro KIMURA <yasu@utahime.org>
To: zsh-workers@zsh.org
Subject: Re: 'make install' fails when build directory is differnet from that of source tree.
Date: Tue, 02 Jun 2020 03:23:45 +0900 (JST)	[thread overview]
Message-ID: <20200602.032345.1340764154463201975.yasu@utahime.org> (raw)
In-Reply-To: <20200601080342.105dbccc@tarpaulin.shahaf.local2>

From: Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: Re: 'make install' fails when build directory is differnet from that of source tree.
Date: Mon, 1 Jun 2020 08:03:42 +0000

> I suspect that extending the last patch (workers/45943) to (1) copy
> Doc/help/ and Doc/help.txt [due to the aforementioned workers/43392],
> and (2) s/cp/cp -p/, would address this.  However, I'm afraid I don't
> currently have time to implement and test this.  If you have time to do
> so, you'll be very welcome; if not, I'll implement that and post the
> patch when I have a minute.

I changed your patch as following.

----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index e78ebf86b..995f010b9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3178,6 +3178,22 @@ AC_CONFIG_COMMANDS([stamp-h], [echo >stamp-h])
 
 AC_OUTPUT
 
+dnl Copy pre-built man pages and help files, for tarball out-of-tree builds.
+for manpage in `cd ${srcdir} && echo Doc/*.1`; do
+  if test x"$manpage" != x"Doc/*.1" && ! test -e "${manpage}"; then
+    cp ${srcdir}/${manpage} ./Doc/
+  fi
+done
+if ! test -e Doc/help.txt; then
+  cp ${srcdir}/Doc/help.txt ./Doc/
+fi
+mkdir -p ./Doc/help
+for helpfile in `cd ${srcdir} && echo Doc/help/*`; do
+  if test x"$helpfile" != x"Doc/help/*" && ! test -e "${helpfile}"; then
+    cp ${srcdir}/${helpfile} ./Doc/help/
+  fi
+done
+
 eval "zshbin1=${bindir}"
 eval "zshbin2=${zshbin1}"
 eval "zshman1=${mandir}"
----------------------------------------------------------------------

Then tarball out-of-tree 'make install.runhelp' succeeds on base
system only FreeBSD 12.1 amd.

---
Yasuhiro KIMURA

  reply	other threads:[~2020-06-01 18:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  6:07 Yasuhiro KIMURA
2020-05-29 22:54 ` Daniel Shahaf
2020-05-29 23:42   ` Daniel Shahaf
2020-05-30  9:05   ` Yasuhiro KIMURA
2020-05-31  1:39     ` Daniel Shahaf
2020-05-31  5:36       ` Yasuhiro KIMURA
2020-05-31  1:57     ` Daniel Shahaf
2020-05-31  7:46       ` Yasuhiro KIMURA
2020-06-01  8:03         ` Daniel Shahaf
2020-06-01 18:23           ` Yasuhiro KIMURA [this message]
2020-06-03  1:14             ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602.032345.1340764154463201975.yasu@utahime.org \
    --to=yasu@utahime.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).