zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Shlomi Fish <shlomif@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: "rpmbuild -tb [tab]" or "rpmbuild -ta [tab]" get stuck / do not complete even if there are tarballs in ./*
Date: Sun, 16 Aug 2020 14:09:46 +0000	[thread overview]
Message-ID: <20200816140946.71036aba@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CANy4znX=5amVu6QpYt6oVFMgtRydSxY2R9DQQJeiLWRiVAa_ZQ@mail.gmail.com>

Shlomi Fish wrote on Tue, 11 Aug 2020 16:57 +0300:
> Hi all!

Morning.

> 
> ```
> shlomif[fcs]:$trunk/fc-solve/B$ pwd
> /home/shlomif/progs/freecell/git/fc-solve/fc-solve/B
> shlomif[fcs]:$trunk/fc-solve/B$ ls *.tar.*
> fc-solve--board-gen--suits-swaps-reports.tar.xz
>  freecell-solver-6.0.1.tar.xz
> freecell-solver-6.0.1.tar.gz
> shlomif[fcs]:$trunk/fc-solve/B$ rpmbuild -tb f[tab]
> ```
> 
> gets stuck. I am on mageia linux v8 with `zsh-5.8-1.mga8`.
> 

So, it's the -t flag with "b" for an argument, so it'll enter the
"build_t" state:

   173	    rpmbuild)
   174	      [[ -prefix -r ]] && pathopts[1]=
   175	      opts+=( $buildopts
   176	        '(-r -t)-b+[build mode (spec file)]:build stage:((p\:execute\ \%prep\ stage l\:do\ a\ list\ check c\:execute\ build\ stage i\:execute\ install\ stage b\:build\ a\ binary\ package a\:build\ binary\ and\ source\ packages s\:build\ source\ package\ only r\:build\ source\ package\ only\ -\ calculate\ build\ requires)):*:build:->build_b'
   177	        '(-b -t)-r+[build mode (source package)]:build stage:((p\:execute\ \%prep\ stage l\:do\ a\ list\ check c\:execute\ build\ stage i\:execute\ install\ stage b\:build\ a\ binary\ package a\:build\ binary\ and\ source\ packages s\:build\ source\ package\ only r\:build\ source\ package\ only\ -\ calculate\ build\ requires)):*:build:->build_b'
   178	        '(-b -r)-t+[build mode (tar file)]:build stage:((p\:execute\ \%prep\ stage l\:do\ a\ list\ check c\:execute\ build\ stage i\:execute\ install\ stage b\:build\ a\ binary\ package a\:build\ binary\ and\ source\ packages s\:build\ source\ package\ only r\:build\ source\ package\ only\ -\ calculate\ build\ requires)):*:build:->build_t'
   179	        --{rebuild,recompile}':*:source rpm file:->build_r'
   180	      )
   181	    ;;

Which will set $tmp:

   283	    build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|

But then nothing reads $tmp.

Does this help?

[[[
diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
index e3469245f..85292fa78 100644
--- a/Completion/Redhat/Command/_rpm
+++ b/Completion/Redhat/Command/_rpm
@@ -282,7 +282,7 @@ _rpm () {
     build_r) tmp=( '*:source package:_files -g "*.(#i)src.rpm(-.)"' ) ;|
     build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
     build_?)
-      _arguments -s -C $buildopts $commonopts $pathopts \
+      _arguments -s -C $buildopts $commonopts $pathopts "${tmp[@]}" \
       ;;
     checksig)
       _arguments -s -C \!-K \
]]]

> One workaround is to prefix the line with "ls " and later remove it.
> 
> Regards,
> 
> -- Shlomi
> 
> P.S: I'd suggest setting up a bug/issue tracker for zsh that tracks
> non-resolved tickets. There are many FOSS, non-FOSS or hosted alternatives.

It's been discussed before.  tl;dr is that we require one with
bidirectional email integration to preserve the existing workflow, but
none has been proposed.

Cheers,

Daniel


  reply	other threads:[~2020-08-16 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 13:57 Shlomi Fish
2020-08-16 14:09 ` Daniel Shahaf [this message]
2020-08-18 13:12   ` Shlomi Fish
2020-08-18 13:46     ` Daniel Shahaf
2020-08-19  7:44       ` Shlomi Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816140946.71036aba@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=shlomif@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).