zsh-workers
 help / color / mirror / Atom feed
* Bug: Missing local decl in _store_cache
@ 2020-09-20 19:33 Jacob Menke
  2020-09-22  7:11 ` Daniel Shahaf
  0 siblings, 1 reply; 2+ messages in thread
From: Jacob Menke @ 2020-09-20 19:33 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hello

The Completion/Base/Utility/_store_cache function is missing the local
declaration for _cache_dir.  Thus it is global.  I do not see any reason
for it to be global seeing that it's value is coming from zstyle in the
function body.

Because _cache_dir is global, it is overwriting my named ~directory for the
compsys compcache directory.

I believe line 5 should be changed to:
local _cache_ident _cache_ident_dir _cache_dir

Thanks
Jacob

[-- Attachment #2: Type: text/html, Size: 595 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: Missing local decl in _store_cache
  2020-09-20 19:33 Bug: Missing local decl in _store_cache Jacob Menke
@ 2020-09-22  7:11 ` Daniel Shahaf
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Shahaf @ 2020-09-22  7:11 UTC (permalink / raw)
  To: Jacob Menke; +Cc: zsh-workers

Jacob Menke wrote on Sun, 20 Sep 2020 15:33 -0400:
> I believe line 5 should be changed to:
> local _cache_ident _cache_ident_dir _cache_dir

Applied, thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-22  7:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 19:33 Bug: Missing local decl in _store_cache Jacob Menke
2020-09-22  7:11 ` Daniel Shahaf

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git