From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: I've caught up on pending commits; how about you?
Date: Tue, 18 May 2021 00:31:10 +0000 [thread overview]
Message-ID: <20210518003110.GA26555@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7ZCz5z2ecNzmp-=J3ENWgTJQ_=S+UquiNWfLwFKi+D0qA@mail.gmail.com>
Bart Schaefer wrote on Sat, May 15, 2021 at 17:40:28 -0700:
> On Sat, May 15, 2021 at 4:22 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > And there's the ctags patch that has been committed with some review
> > points outstanding. A glance at _ctags in master shows that external
> > command output is passed to _values' «spec» arguments unsanitized.
>
> I don't have access to the ctags variant that supports
> --list-languages, but I presume you're referring to
>
> _values -s , languages $languages
Yes.
> The value of $languages comes from _ctags_languages which produces
> only strings matching the sed pattern
> [A-Za-z][A-Za-z0-9#_+]*
>
> What additional sanitation do you feel is needed? This was done in
> response to your previous criticism of this point.
None, sorry, this seems fine. I'd missed the sed, sorry.
> As far as I can tell the only un-address review points are from
> Oliver's workers/48296
Thanks.
Daniel
prev parent reply other threads:[~2021-05-18 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 21:32 Bart Schaefer
2021-05-15 23:20 ` Daniel Shahaf
2021-05-16 0:40 ` Bart Schaefer
2021-05-18 0:31 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518003110.GA26555@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).